New issue
Advanced search Search tips

Issue 839270 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 832173



Sign in to add a comment

Regression : Focus ring on 'Advanced' option appears thick in size in settings page.

Reported by avsha...@etouch.net, May 3 2018

Issue description

Chrome Version : 68.0.3418.0 (Official Build) 5319d9b60c08fee2ca45593c7a67688408ce5d73-refs/heads/master@{#555651} 32/64-bit
OS : Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings page.
2. Open 'Main menu' and press Tab key to bring focus on 'Advanced' option.
3. Observe the focus ring.

Actual Result : Focus ring on 'Advanced' option appears thick in size.

Expected Result : Focus ring on 'Advanced' option should be thin in size as expected.

(Focus ring for other options in 'Main menu' is seen as expected.)

This is a regression issue, broken in M-68 and will soon update other info
Good Build : 68.0.3417.0 (Revision : 555218)
Bad Build : 68.0.3418.0 (Revision : 555651)
 
Focus_Ring.png
10.6 KB View Download
Expected_Focus.mp4
336 KB View Download
Actual_Focus.mp4
407 KB View Download
Labels: hasbisect-per-revision RegressedIn-68 FoundIn-68 Target-68 OS-Linux
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : Focus ring on 'Advanced' option appears thick in size in settings page. (was: Regression : Focus ring on 'Advanced' option appears thick in size.)
This is a regression issue, broken in M-68 and providing the bisect using per-revision script:
Good Build : 68.0.3417.0 (Revision : 555218)
Bad Build : 68.0.3418.0 (Revision : 555651)

You are probably looking for a change made after 555255 (known good), but no later than 555256 (first known bad).

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/abf2ce0e99d7b92eeebed86018e186aec516d249..c0f34fbc93cc949bcf8c959b9d21b15cb83c8080

Suspect : https://chromium.googlesource.com/chromium/src/+/c0f34fbc93cc949bcf8c959b9d21b15cb83c8080

@dpapad : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue is also observed on Linux(14.04 LTS) OS but the same issue is not seen on Mac(10.12.6, 10.13.1, 10.13.5) OS.

Comment 2 Deleted

Status: Started (was: Assigned)
Blocking: 832173
Project Member

Comment 6 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20376bcfe574adb3f11e5984b39fffea90542d7f

commit 20376bcfe574adb3f11e5984b39fffea90542d7f
Author: dpapad <dpapad@chromium.org>
Date: Sat May 05 02:33:36 2018

Settings WebUI: Undo default box-shadow style for advanced toggle.

Bug:  839270 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7af505de122b071846617c95dd20454214c49275
Reviewed-on: https://chromium-review.googlesource.com/1043268
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556296}
[modify] https://crrev.com/20376bcfe574adb3f11e5984b39fffea90542d7f/chrome/browser/resources/settings/settings_menu/settings_menu.html

Labels: TE-Verified-M68 TE-Verified-68.0.3423.0
Update : 
Retested above issue in latest Canary build #68.0.3423.0 on Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Focus on 'Advanced' option appears proper in size. Kindly review an attached screen-cast.

Thank you..!
Canary_Result.mp4
367 KB View Download
Status: Fixedh (was: Started)
Status: Fixed (was: Fixedh)
Labels: Proj-MaterialDesign-Refresh-WebUI

Sign in to add a comment