New issue
Advanced search Search tips

Issue 839265 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 705591



Sign in to add a comment

Replace references to ash::DisplayManager in src/chrome with cros_display_config.mojom calls

Project Member Reported by steve...@chromium.org, May 3 2018

Issue description

Now that cros_display_config.mojom exists we can replace any remaining calls to DisplayManager (and other ash/display dependencies) with mojo API calls.

e.g. chrome/browser/chromeos/preferences.cc

 
OutputProtectionControllerAsh could be converted also, but will need additional support in the mojo API.

Labels: M-68
Blockedon: 705591
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af7c185b4c3ca14750eebb6da82a4d57827c8c20

commit af7c185b4c3ca14750eebb6da82a4d57827c8c20
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed May 23 20:14:32 2018

ChromeInternalLogSource: Get display info using mojo

Test: Visit chrome://system, search for 'monitor_info', ensure
information there is correct/consistent. (Test with multiple
displays).

Bug:  839265 
Change-Id: I9b11d5d9dba31ab498954aee7d08a328c3457203
Reviewed-on: https://chromium-review.googlesource.com/1070315
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561229}
[delete] https://crrev.com/203891782014f6bbc9d84be8ec32f368388485a3/chrome/browser/feedback/system_logs/log_sources/DEPS
[modify] https://crrev.com/af7c185b4c3ca14750eebb6da82a4d57827c8c20/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/af7c185b4c3ca14750eebb6da82a4d57827c8c20/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h

Status: Fixed (was: Started)
The only remaining non test references to display_manager.h are:
* display_rotation_default_handler.cc:  issue 705713 
* arc_screen_capture_session.cc: 706246
* keyboard_overlay_ui.cc: 770866

Sign in to add a comment