New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839252 link

Starred by 1 user
Status: Fixed
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
xiy...@chromium.org
█ hejq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Regression: cannot open context menu for search result apps

Project Member Reported by warx@chromium.org, May 3 2018 
Repro steps:
long press or right click on apps on peeking launcher, could not open context menu

Regression comes from crrev.com/c/1029541

Since jiaquan is OOO, I could take a look as this is pretty urgent.

Comment 1 by hejq@chromium.org, May 3 2018 

Oops sorry I broke things again. Here's the path showing the context menu:

Views -> AppListViewDelegate -> AppListControllerImpl -> AppListClientImpl -> AppListModelUpdater -> ChromeSearchResult -> [returns]

I hope this is helpful.
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69feef31581454d944dae3970505209ef6b6563b

commit 69feef31581454d944dae3970505209ef6b6563b
Author: Qiang Xu <warx@google.com>
Date: Fri May 04 15:57:08 2018

cros: fix not able to open search result context menu

A typo fix

Bug:  839252 
Test: tested on device
Change-Id: Ic56d3324212b23d23d6782bc082e3765f996eedd
Reviewed-on: https://chromium-review.googlesource.com/1043396
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#556071}
[modify] https://crrev.com/69feef31581454d944dae3970505209ef6b6563b/chrome/browser/ui/app_list/app_list_client_impl.cc

Comment 3 by warx@chromium.org, May 4 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment