"Also, do we have auto-test for fileManager in any mode, clamshell, tablet, ..." was a question for zork@ 

Blocking  issue 843030  (browser test renaming issue, wherein I can add support for FileManager browser tests in Tablet mode).

achuith: Is there an easy way to force tablet mode for our tests?

Upping the pri, ideally we land this early in the M-69 cycle.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91b6a17ec74ca5e7c40a05662a21ff6d6cc3e81a

commit 91b6a17ec74ca5e7c40a05662a21ff6d6cc3e81a
Author: Noel Gordon <noel@chromium.org>
Date: Thu May 24 11:11:30 2018

Add tablet mode to FilesAppBrowserTest TestCase parameter

Bug:  839243 
Change-Id: I9a726ce45a4ff500835dd8fdcd1372169250527e
Reviewed-on: https://chromium-review.googlesource.com/1071415
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561457}
[modify] https://crrev.com/91b6a17ec74ca5e7c40a05662a21ff6d6cc3e81a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ba5cc7035ed1688a4741f004ae59526a1132fd7

commit 7ba5cc7035ed1688a4741f004ae59526a1132fd7
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 25 00:57:54 2018

FilesAppBrowserTest: enable tablet mode and add initial tests

Enable tablet mode using Ash switches. Add new FileDisplay tests; make
them run in tablet mode (for starters, more in future changes).

FileDisplay tests are not supported on Mash: so add Mash exclusions to
the Mash bot filter list for the new tests herein:

  FileDisplay/FilesAppBrowserTest.Test/fileDisplayDownloads_TabletMode
  FileDisplay/FilesAppBrowserTest.Test/fileDisplayDrive_TabletMode

Minor: add trusted event dispatch clean-up TODO.

Test=browser_test --gtest_filter="FileDisplay/FilesAppBrowser*"

No-Presubmit: true
Bug:  839243 
Change-Id: I0349d9f9292d4ac5c02470a6f8d98105af2f86ab
Reviewed-on: https://chromium-review.googlesource.com/1071501
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561714}
[modify] https://crrev.com/7ba5cc7035ed1688a4741f004ae59526a1132fd7/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/7ba5cc7035ed1688a4741f004ae59526a1132fd7/testing/buildbot/filters/mash.browser_tests.filter

Removing the milestone as this is an ongoing effort.

Virtual keyboard + Table Mode go together.

That does not happen in a browser test so we need to make it happen (see issue 879434) and also suggests there are no real tests of these features working together ...  

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c480691dbc893c156f0ee9880e1c46fa482a5766

commit c480691dbc893c156f0ee9880e1c46fa482a5766
Author: Noel Gordon <noel@chromium.org>
Date: Thu Sep 06 04:40:30 2018

Allow browser test base class to read tablet mode test state

Propagate the Table Mode (aka Ash immersive mode) test state into the
base class of the Files App test suite.

Make Tablet Mode tests enable the Ash Virtual Keyboard flag (as would
happen on real chromebook in Table Mode).

No change in test behavior: just erecting the scaffold so we can test
this aspect of Chrome OS.

Bug: 879434,  839243 
Change-Id: Idfd4016698214876c991d26d1a3a8fd7dfa84bde
Reviewed-on: https://chromium-review.googlesource.com/1207783
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589100}
[modify] https://crrev.com/c480691dbc893c156f0ee9880e1c46fa482a5766/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/c480691dbc893c156f0ee9880e1c46fa482a5766/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/c480691dbc893c156f0ee9880e1c46fa482a5766/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef50a96dea8eb8f55cac68d86784d3b5e749dee7

commit ef50a96dea8eb8f55cac68d86784d3b5e749dee7
Author: Noel Gordon <noel@chromium.org>
Date: Thu Nov 08 03:40:47 2018

Make all elements query test helpers return the client's top and left

These test helpers return an element's getBoundingClientRect width and
height only. Include the DOMRect .top and .left as well [1].

[1] Useful for table mode + touch event testing, should be the same as
W3C DOMRect .x and .y values. Would prefer those, but closure does not
define them [2] whereas the W3C DOM specs do.

[2] Filed https://github.com/google/closure-compiler/issues/3140

Bug:  839243 
Change-Id: I0cce0e4a121fd7bca49645d09e98d013fbf920f0
Reviewed-on: https://chromium-review.googlesource.com/c/1325270
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606322}
[modify] https://crrev.com/ef50a96dea8eb8f55cac68d86784d3b5e749dee7/ui/file_manager/file_manager/background/js/test_util_base.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45a8716f391142751234187fdf367376ae9164a5

commit 45a8716f391142751234187fdf367376ae9164a5
Author: Noel Gordon <noel@chromium.org>
Date: Thu Nov 15 08:05:37 2018

Comment fix: say tablet mode

Ash immersive mode is not quite right anymore: remove it.

Bug:  839243 
No-Try: true
Change-Id: If25f8e3411006c694825a38841fd1ae92f287623
Reviewed-on: https://chromium-review.googlesource.com/c/1336951
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608293}
[modify] https://crrev.com/45a8716f391142751234187fdf367376ae9164a5/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h

We have sufficient tools in the integration tests in table mode.