New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839210 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

StopVm should return success if the requested VM does not exist

Project Member Reported by rjwright@chromium.org, May 3 2018

Issue description

The StopVm method in concierge/service.cc returns an error state if the named VM does not exist. This happens concierge does not have the named VM in its list of VMs because the VM has never been started or has already been stopped.

We have to check the failure reason here

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/crostini/crostini_manager.cc?l=673

because we want the uninstall process to continue even if the VM is not currently running. It would be better to have this condition return success than to have to discriminate on failure reason.
 
Labels: Hotlist-Crostini-UI
The command-line message should also not indicate error - just notify. See also crbug.com/827223
Status: Fixed (was: Started)
I believe this was fixed in https://crrev.com/c/1325709

Sign in to add a comment