New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839206 link

Starred by 3 users
Status: Fixed
Owner:
█ rjwright@chromium.org
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

VmConcierge terminology is confusing

Project Member Reported by rjwright@chromium.org, May 3 2018 
Method names like StartVmConcierge are confusing. This has come up a few times in reviews, and also confuses me sometimes even though I know what it means.

Should be changed to just StartConcierge etc.
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bfe4c8bb8e2e6be50e537978e32ac0199c88772

commit 1bfe4c8bb8e2e6be50e537978e32ac0199c88772
Author: Renee Wright <rjwright@chromium.org>
Date: Tue May 08 05:19:52 2018

Rename *VmConcierge methods to *Concierge

Method names such as StartVmConcierge are confusing. Rename to
StartConcierge etc.

third_party/cros_system_api/dbus/debugd/dbus-constants.h still has

const char kStartVmConcierge[] = "StartVmConcierge";
const char kStopVmConcierge[] = "StopVmConcierge";

as these need to match the method names in the service.

Bug:  839206 
Change-Id: I48800e595a2756fd8bc8d35ca136dd73a825b08e
Reviewed-on: https://chromium-review.googlesource.com/1041365
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556696}
[modify] https://crrev.com/1bfe4c8bb8e2e6be50e537978e32ac0199c88772/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/1bfe4c8bb8e2e6be50e537978e32ac0199c88772/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/1bfe4c8bb8e2e6be50e537978e32ac0199c88772/chrome/browser/chromeos/crostini/crostini_remover.cc
[modify] https://crrev.com/1bfe4c8bb8e2e6be50e537978e32ac0199c88772/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc
[modify] https://crrev.com/1bfe4c8bb8e2e6be50e537978e32ac0199c88772/chromeos/dbus/debug_daemon_client.cc
[modify] https://crrev.com/1bfe4c8bb8e2e6be50e537978e32ac0199c88772/chromeos/dbus/debug_daemon_client.h
[modify] https://crrev.com/1bfe4c8bb8e2e6be50e537978e32ac0199c88772/chromeos/dbus/fake_debug_daemon_client.cc
[modify] https://crrev.com/1bfe4c8bb8e2e6be50e537978e32ac0199c88772/chromeos/dbus/fake_debug_daemon_client.h

Comment 2 by rjwright@chromium.org, May 22 2018

Status: Fixed (was: Started)
►

Sign in to add a comment