New issue
Advanced search Search tips

Issue 839202 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Ensure that OWNERS checks still run on TBRed CLs

Project Member Reported by dcheng@chromium.org, May 3 2018

Issue description

Currently, if TBR is in the review line and there are no OWNERS files in the change, we just skip the OWNERS check completely.

We should at least check that the TBR line contains the right set of reviewers.

(Also, does Gerrit actually guarantee that TBRed reviewers are actually added to the review?)
 
Status: Available (was: Unconfirmed)
https://chromium-review.googlesource.com/c/chromium/src/+/1176621 is an example of a CL that didn't actually include all the proper reviewers but was still landed due to tbr

Sign in to add a comment