Is this issue happening with M65?

Apologies, I meant to look into this yesterday but did not get to it and I am going to be OOO on vacation next week.

If we think this is urgent for 66, the code that *should* be updating the button state is here:

https://cs.chromium.org/chromium/src/ui/webui/resources/cr_components/chromeos/network/network_config.js?dr&q=network_config&sq=package:chromium&l=304

Which should be calling setSelectedCerts_ which should call updateIsConfigured_().

It's possible that this change is missing in 66, which might cause the problem:
https://chromium-review.googlesource.com/c/chromium/src/+/1022331/3/ui/webui/resources/cr_components/chromeos/network/network_config.js

tbarzic@ or benchan@ should be able to fix this assuming they can repro it.

If we don't think it's urgent for 66 (it is kind of an edge case) I can fix it for 67 when I get back.

I'd say it's urgent because now 100% of our users who have gotten the new version are unable to access corporate resources. We've told everyone to not reboot their chromebooks, but there's no guarantee they'll be able to avoid it.

I found that if you disable chrome://flags/#disable-network-settings-config it looks and works like it used to in Chrome OS 65 and earlier. This not an elegant solution for IT to manage many live devices in users hands. 

RE: #c5
Thanx for that, my PIA VPN is working again.

The issue is not in 65, that uses the old networking config UI.

I can reproduce this in 66, but it is subtle. The certificate has to be installed while the dialog is open, which is kind of an edge case. Changing any other field (except selecting the certificate) will enable the 'connect' button. So there are easy workarounds.

This is fixed in 67+.

So, I am going to close this WontFix since it only affects 66, which is already stable and this doesn't really seem worth fixing there.

Can I get my hands on a 67+ version to verify? Or send one of our .onc files for y'all to verify in 67+?

My nightmare would be 67 coming out, the old UI be unavailable, and we have no workaround if 67 doesn't actually fix the issue.

bri@ - Did you try changing one of the other fields (e.g. username)? That should enable the 'Connect' button.

Also, how are you using the .onc file? The repro does not say anything about enterprise enrollment. Could you maybe provide your specific repro?

(Also, the Beta channel should be on 67 now, you can set that in Settings > About Chrome OS > Detailed build information)

steve...@  - We've been installing the .onc files to chromebooks via  chrome://net-internals/#chromeos

That's been our only option because we have tried many times to be able to create the VPN config via the admin.google.com control panel and was never successful.

We're taking a look at 67 shortly via beta channel.

I see. Unfortunately that's not a path we have been able to fully support, but if 67 doesn't work for you, please go ahead and attach an ONC file similar to what you are using (you can change the values, I don't need to actually connect, just test the UI). Or you can email it to stevenjb @ chromium.org.

Hi Steve,

I've sent over an email with our onc file for debugging. I did import this file into 67 beta (67.0.3396.41) and it had the same issue as 66. 

After more discussion I discovered the specific issue in 67+:

The previous (non Settings based) config UI enables 'Connect' even when no certs are installed. Incongruously it will always select a cert if one is installed, so the no user cert scenario only kind-of works in the old UI.

I don't see any reason to disallow a "no user cert" configuration if there are valid use cases for that.

cernekee@ - WDYT?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a02de1ab8e0c82fc05daaf68af1c1532998a48f6

commit a02de1ab8e0c82fc05daaf68af1c1532998a48f6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue May 22 16:57:11 2018

Network config: Support OpenVPN with no user cert

Bug:  839195 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I20514f612345a16629e5a1370277885b6b2e3ad3
Reviewed-on: https://chromium-review.googlesource.com/1066610
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560657}
[modify] https://crrev.com/a02de1ab8e0c82fc05daaf68af1c1532998a48f6/chrome/app/settings_strings.grdp
[modify] https://crrev.com/a02de1ab8e0c82fc05daaf68af1c1532998a48f6/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/a02de1ab8e0c82fc05daaf68af1c1532998a48f6/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/a02de1ab8e0c82fc05daaf68af1c1532998a48f6/ui/webui/resources/cr_components/chromeos/network/network_config.js

We need to verify this on 68 asap so we can merge to 67. Hopefully tonight's PFQ build will succeed.

This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Have you been able to verify?

It looks like last night's PFQ build is just now building in GoldenEye, CrOS build 10710.0.0, so hopefully this can be verified later today or early tomorrow.

pending #18/#19

Hello,
I am still seeing this issue on Version 68.0.3431.0 (Official Build) dev (64-bit) running on a Pixel book.

Also, trying the work around in c5 does not work on this build.

Re: comment #21 / 22: If the workaround in comment #5 does not work, that suggests you are attempting to use an unsupported configuration, are you setting a username? With the patch in comment #15 username will be optional, so that may address your situation.

68.0.3431.0 was built on May 15 (the build date can be found at the bottom of Settings > About > Detailed build info), before the patch.

The fix in comment #15 is in 68.0.3438.

Yes, I was supplying a username and a password, but the connect button is still grayed out.

Once update 68.0.3438+ is released for my PixelBook, I will retest.

When connecting to OpenVPN, 'Connect' is clickable with no user cert installed. Verified on Samus, Nautilus R68-10718.4.0

Is #25 a confirmation of the fix through testing?  Comments #21-24 make it fuzzy.

Yes, at least it describes the correct behavior. This should be marked as Verified.

(And merged ASAP... :) )

Merge approved for M67 Chrome OS.  Please try to merge soon (per #28) so we can catch in time for the candidate.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d1b4c016c7391dc385cecbec7fefb5aa36bcb9

commit 02d1b4c016c7391dc385cecbec7fefb5aa36bcb9
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jun 05 18:11:41 2018

Network config: Support OpenVPN with no user cert

TBR=stevenjb@chromium.org

(cherry picked from commit a02de1ab8e0c82fc05daaf68af1c1532998a48f6)

Bug:  839195 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I20514f612345a16629e5a1370277885b6b2e3ad3
Reviewed-on: https://chromium-review.googlesource.com/1066610
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560657}
Reviewed-on: https://chromium-review.googlesource.com/1087538
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#751}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/02d1b4c016c7391dc385cecbec7fefb5aa36bcb9/chrome/app/settings_strings.grdp
[modify] https://crrev.com/02d1b4c016c7391dc385cecbec7fefb5aa36bcb9/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/02d1b4c016c7391dc385cecbec7fefb5aa36bcb9/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/02d1b4c016c7391dc385cecbec7fefb5aa36bcb9/ui/webui/resources/cr_components/chromeos/network/network_config.js