New issue
Advanced search Search tips

Issue 839188 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

tryjobs: detect dependencies automatically

Project Member Reported by briannorris@chromium.org, May 3 2018

Issue description

I have a stack of a dozen+ CLs, and I've run commands like this with the top 1 or 2 CLs included, assuming the tryjob would nicely pick up the dependencies:

cros tryjob -g 1036362 -g 1036361 elm-no-vmtest-pre-cq

And I get builder errors like this:

"CL:1036361 depends on CL:1036360, which is not marked Commit-Queue>=+1"

I'm told this is currently intentional: one must include all dependencies in the tryjob invocation.

Feature request: it seems like the sync stage should just pull in the dependencies, so one only has to include the "top" CL in a stack.

Alternatively: clean up the error message to be clearer; the problem is not that it's not marked CR+1; the problem is that the CL was not in the tryjob invocation. (Similarly, when I didn't mark V+1, it complained about that too. That's counterintuitive, since the whole point of the tryjob was so that I could get some verification.)
 

Sign in to add a comment