New issue
Advanced search Search tips

Issue 839181 link

Starred by 1 user
Status: Fixed
Owner:
amaralp@chromium.org
Closed: May 2018
Cc:
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Tab switching animation doesn't work with bottom toolbar

Project Member Reported by amaralp@chromium.org, May 3 2018 
Chrome Version: M68
OS: Android

What steps will reproduce the problem?
(1) Enable "Chrome Duplex" in chrome://flags
(2) Tap the tab switcher button
(3) Tap on a tab to switch to it (could even be the original tab)

What is the expected result?
Tab switching animation should be smooth

What happens instead?
Tab switching animation moves tapped tab about half an inch below where 
it should be. Then the UI jumps up to fill the entire screen.
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25744d682beff730f4856061db30c4d24639cf0

commit e25744d682beff730f4856061db30c4d24639cf0
Author: Pedro Amaral <amaralp@chromium.org>
Date: Thu May 03 20:17:42 2018

Fixing tab switching animation when bottom toolbar is visible

When selecting a tab in the tab switcher the animation that brought
the selected tab to full-screen placed offset the tab down and this
led to janky looking animation. This happened because the tab switcher
animation code assumed that the browser controls only contained the top
bar. This CL fixes that assumption.

Bug:  839181 
Change-Id: Ide349b8bcd5290acd8a8d9cde80b6f10886ac177
Reviewed-on: https://chromium-review.googlesource.com/1041162
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555855}
[modify] https://crrev.com/e25744d682beff730f4856061db30c4d24639cf0/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java
[modify] https://crrev.com/e25744d682beff730f4856061db30c4d24639cf0/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimation.java
[modify] https://crrev.com/e25744d682beff730f4856061db30c4d24639cf0/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java
[modify] https://crrev.com/e25744d682beff730f4856061db30c4d24639cf0/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationPortrait.java

Comment 2 by amaralp@chromium.org, May 11 2018

Status: Fixed (was: Started)
►

Sign in to add a comment