New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839180 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[desktop-pwas] Title bar UI should tabbable through the normal page tab order

Project Member Reported by mgiuca@chromium.org, May 3 2018

Issue description

Chrome Version: 67.0.3396.26
OS: Chrome

What steps will reproduce the problem?
(1) Open an installed PWA in a window.
(2) Continually press the Tab key.

What is the expected result?
Tab cycles through all of the elements on the page, then focuses the title bar elements (permissions, app menu, but not the caption buttons) and cycles those.

Also, if Alt+Shift+T is used to focus title bar, tab should cycle back into the page elements.

Basically, merge the title bar and page elements into a single sequence rather than two separate sequences (because this is not a browser / page relationship, it's all part of the app UI).

What happens instead?
Tab cycles through just the elements on the page.

If Alt+Shift+T is used to focus title bar, tab only cycles through the title bar elements.
 

Comment 1 by mgiuca@chromium.org, Jun 18 2018

Labels: -M-68 M-69
Bulk punting M68 PWA bugs to M69.
WIP screencast for: https://chromium-review.googlesource.com/c/chromium/src/+/1114401
Video-Tue-Jun-26-2018-13-51-26.webm
1.8 MB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1f341badeb00de2dd1c1674332fcb0c5a910274

commit b1f341badeb00de2dd1c1674332fcb0c5a910274
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Jun 28 02:25:06 2018

Add hosted app menu button to tabbable focus cycle

This CL enables users to tab to the hosted app menu button in hosted app
windows from the web contents.

The related browser test has been updated with secure site navigation to
add coverage for PWA hosted app windows.

Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=345540&signed_aid=5deNZnjPxp-be66iybEtaw==&inline=1

Bug:  839180 
Change-Id: Ibf4b4dab6bd6b4c5d721a9a2200477a56e4644a7
Reviewed-on: https://chromium-review.googlesource.com/1114401
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571002}
[modify] https://crrev.com/b1f341badeb00de2dd1c1674332fcb0c5a910274/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/b1f341badeb00de2dd1c1674332fcb0c5a910274/chrome/browser/ui/views/frame/hosted_app_menu_button.cc

Status: Fixed (was: Assigned)

Sign in to add a comment