New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839177 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 823628



Sign in to add a comment

[desktop-pwas] ChromeVox should announce window title when opening window

Project Member Reported by mgiuca@chromium.org, May 3 2018

Issue description

Chrome Version: 67.0.3396.26
OS: Chrome

What steps will reproduce the problem?
(1) Turn on ChromeVox (Ctrl+Alt+Z).
(2) Open a PWA app window.

What is the expected result?
ChromeVox should announce: "Window $APPNAME, by $ORIGIN".

For example, "Window The Air Horner, by airhorner dot com".
(It is a a security requirement to show the origin, so we should also announce it.)

What happens instead?
Sometimes it announces just the name: "Window The Air Horner tab".

Other times it announces the URL: "Window https colon slash slash airhorner dot com".

Seems inconsistent; possibly a race condition to load the page title.

In 1:1 with me and lpalmaro@, we agreed to try and fix/merge it to 67, but it was not critical because the URL is already announced. However, I later discovered the above alternative case that it just reads the title and not the URL. Laura, does this upgrade the urgency of this fix?
 
Labels: -Pri-2 Pri-1
WIP screenshot:
chromevox-origin.png
30.7 KB View Download
From talking with aboxhall we don't really craft what the screenreader says directly, we describe to it the semantic model of the UI the user is interacting with and it decides how it wants to convey that. This makes it a bit difficult to make it say `Window ${title}, by ${origin}`.

Within the constraints of the AxNodeData API I've gotten it to say:
> tab created
> window Progressive Web Flap tab
> progressivewebflap.com
> Application
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11b61e95bbe43e0d7b1f17751320795d40b4db1e

commit 11b61e95bbe43e0d7b1f17751320795d40b4db1e
Author: Alan Cutter <alancutter@chromium.org>
Date: Wed May 23 02:29:43 2018

Notify accessibility of origin string when PWA window opened

The origin string is displayed in the title bar when PWA windows
are opened as a security precaution. This CL ensures it is also
spoken by ChromeVox for accessibility.

Bug:  839177 
Change-Id: I622c45517ecddd2d85f680ae0fcae225e5be3ed9
Reviewed-on: https://chromium-review.googlesource.com/1068891
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560902}
[modify] https://crrev.com/11b61e95bbe43e0d7b1f17751320795d40b4db1e/ash/frame/frame_header_origin_text.cc
[modify] https://crrev.com/11b61e95bbe43e0d7b1f17751320795d40b4db1e/ash/frame/frame_header_origin_text.h

Status: Fixed (was: Assigned)

Sign in to add a comment