New issue
Advanced search Search tips

Issue 839158 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Error in ZipArchiver OnSuspend event

Project Member Reported by noel@chromium.org, May 2 2018

Issue description

Extension dmboannefpncccogfdikhmhpmdnddgoe is the 'ZipArchiver'.  Running browser tests, the following error is LOG-ed sometimes when handling chrome.runtime.OnSuspend
 
[47757:47757:0503/004508.504195:INFO:CONSOLE(0)] "Error in event handler for runtime.onSuspend: TypeError: The first argument is the receiver and must be an object", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0)

Should I worry?

 

Comment 1 by noel@chromium.org, May 2 2018

Labels: CrOSFilesCategory-Testing
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83eea24bb70cd3acb379a92e45003e5aa03075a7

commit 83eea24bb70cd3acb379a92e45003e5aa03075a7
Author: Tatsuhisa Yamaguchi <yamaguchi@google.com>
Date: Tue May 08 11:59:09 2018

Prevent runtime errors on suspend events.

unpacker.app.onSuspend was removed at f878141 and no longer exists.
https://chromium-review.googlesource.com/940742

Bug:  839158 , 789073 , 803752 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I973b7728095cddcceab2e58c06ca07986a6bd9e6
Reviewed-on: https://chromium-review.googlesource.com/1049417
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556763}
[modify] https://crrev.com/83eea24bb70cd3acb379a92e45003e5aa03075a7/chrome/browser/resources/chromeos/zip_archiver/js/background.js

Status: Fixed (was: Started)
I think this has been resolved by the revision.
Which was the test case in browser_tests that had the error message?

Comment 5 by noel@chromium.org, May 9 2018

Any fo the ones that use NaCl. "/FileManagerBrowserTest*"

Comment 6 by noel@chromium.org, May 9 2018

I went and read went LOGs for ~10min to see if I could find one and failed.

Since you have removed the offending code, we can just close here since there is truck load of other LOG error messages we should go fix.

Comment 7 by noel@chromium.org, May 11 2018

Found one: VideoPlayerBrowserTest.OpenSingleVideoOnDownloads (CRASHED) ASAN
  http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/27201

Build log:

[28281:28281:0426/011811.065102:INFO:CONSOLE(0)] "Error in event handler for runtime.onSuspend: TypeError: The first argument is the receiver and must be an object", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0)
[28281:28281:0426/011811.583009:INFO:CONSOLE(0)] "[SUCCESS] [openSingleVideoOnDownloads]", source: chrome-extension://ljoplibgfehghmibaoaepfagnmbbfiga/_generated_background_page.html (0)

(as reported in another unrelated  issue 837950  that flakes our tests).

Sign in to add a comment