New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839150 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

move RecommendationRestorer to ash

Project Member Reported by warx@chromium.org, May 2 2018

Issue description

RecommendationRestorer has no dependency on chrome/. The only thing we need to take care is to regulate that it starts observing recommendation values before starting observing user setting values.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d

commit d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d
Author: Qiang Xu <warx@google.com>
Date: Thu May 24 20:07:57 2018

cros: move recommendation restorer to ash

This CL moves RecommendationRestorer class to ash. The class exposes
an ObservePrefs method to let caller start observing recommended values
for a pref name.

TBR=bartfab@chromium.org

Bug:  839150 
Test: covered by tests and enterprise-enrolled device test
Change-Id: I57b80c49ff8b0d5ab27102abf57b9a21b6b95c0a
Reviewed-on: https://chromium-review.googlesource.com/1023158
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561591}
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/BUILD.gn
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/DEPS
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/accessibility/accessibility_controller.cc
[add] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/policy/policy_recommendation_restorer.cc
[add] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/policy/policy_recommendation_restorer.h
[add] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/policy/policy_recommendation_restorer_unittest.cc
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/session/test_session_controller_client.cc
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/session/test_session_controller_client.h
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/shell.cc
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/ash/shell.h
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/7f0cff2a447c312a5e29925fa88d323732a2c806/chrome/browser/chromeos/policy/recommendation_restorer.cc
[delete] https://crrev.com/7f0cff2a447c312a5e29925fa88d323732a2c806/chrome/browser/chromeos/policy/recommendation_restorer.h
[delete] https://crrev.com/7f0cff2a447c312a5e29925fa88d323732a2c806/chrome/browser/chromeos/policy/recommendation_restorer_factory.cc
[delete] https://crrev.com/7f0cff2a447c312a5e29925fa88d323732a2c806/chrome/browser/chromeos/policy/recommendation_restorer_factory.h
[delete] https://crrev.com/7f0cff2a447c312a5e29925fa88d323732a2c806/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/d8e897e89c7fbd0ea81994f2a5cb445cd478bb7d/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

Comment 2 by warx@chromium.org, May 24 2018

Status: Fixed (was: Assigned)

Sign in to add a comment