New issue
Advanced search Search tips

Issue 839143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Turn off MCVD for M67

Project Member Reported by liber...@chromium.org, May 2 2018

Issue description

Since it's not handling gpu sync tokens properly, it's safer to turn off MCVD for 67 in favor of the already-shipping AVDA.  We can try again in 68.
 
Labels: Merge-Request-67
Requesting merge to M67.  TL;DR: it's a very small change to a feature setting (ENABLED_BY_DEFAULT => DISABLED_BY_DEFAULT).  I'd like to keep it on @ ToT.

Do I need to land this @ToT => merge to 67 => re-enable @ToT, or can i just cherry-pick it directly to 67?

CL is https://chromium-review.googlesource.com/c/chromium/src/+/1040867
Project Member

Comment 2 by sheriffbot@chromium.org, May 2 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by cmasso@google.com, May 4 2018

I think it is ok to land it into M67 right away.
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f7ef87d5d3e16e2a4be89a19c9713b6a2801b58

commit 9f7ef87d5d3e16e2a4be89a19c9713b6a2801b58
Author: liberato@chromium.org <liberato@chromium.org>
Date: Fri May 04 21:25:36 2018

Turn off MojoVideoDecoder for Android.

Bug:  839143 
Change-Id: I60e2e13be1ef21839e5e653e77acca62edebd8fb
Reviewed-on: https://chromium-review.googlesource.com/1045186
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#490}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/9f7ef87d5d3e16e2a4be89a19c9713b6a2801b58/media/base/media_switches.cc

Labels: -Hotlist-Merge-Review -Merge-Review-67
Please verify and close.
it just missed the previous beta cut, so we should know thursday if this worked.
Status: Fixed (was: Assigned)

Sign in to add a comment