New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839141 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Pinning terminal or Linux app to shelf doesn't survive reboot

Project Member Reported by whewatt@google.com, May 2 2018

Issue description

Chrome version: (copy from chrome://version)
OS: 68.0.3416.0 (Official Build) dev (64-bit)

Repro steps:
1. Start Terminal or another Linux app
2. Pin the icon to the shelf
3. Reboot Pixelbook

Expected: Terminal/Linux icons should remain on shelf
Actual: Icons are not on shelf

 
Owner: timloh@chromium.org
Status: Assigned (was: Untriaged)
Yep, repros >_<... Will have a look shortly
Labels: -Pri-2 M-68 Pri-1

Comment 3 by jmeurin@google.com, May 3 2018

The pinning was gone even after just a suspend/resume.
Cc: xllora@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/366731bb14a1f1b160e7156448a3b56dca5648c7

commit 366731bb14a1f1b160e7156448a3b56dca5648c7
Author: Timothy Loh <timloh@chromium.org>
Date: Fri May 04 06:14:24 2018

Fix pinned Crostini apps disappearing on restore

This patch fixes LauncherControllerHelper::IsValidIDForCurrentUser to
handle Crostini apps, so that the restore process can correctly add
pinned Crostini apps.

TEST=Manually verified both the Terminal and installed Crostini apps
re-appear after reboot.

Bug:  839141 
Change-Id: I09a40a9f24779b19a2b1bae1c21f9a33e0ae1708
Reviewed-on: https://chromium-review.googlesource.com/1043665
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555999}
[modify] https://crrev.com/366731bb14a1f1b160e7156448a3b56dca5648c7/chrome/browser/ui/ash/launcher/launcher_controller_helper.cc

Status: Fixed (was: Assigned)
Components: OS>Systems>Containers

Comment 8 by timloh@chromium.org, May 16 2018

Cc: nverne@chromium.org
 Issue 843193  has been merged into this issue.

Comment 9 by vapier@chromium.org, May 17 2018

Labels: -Restrict-View-Google

Sign in to add a comment