Issue metadata
Sign in to add a comment
|
crosperf: Some boards error out when writing to /sys/devices/system/cpu/intel_pstate/no_turbo |
||||||||||||||||||||||
Issue description
ATAL: Could not pin frequencies on machine: chromeos2-row9-rack7-host9.cros
File "/usr/lib/python2.7/threading.py", line 774, in __bootstrap
self.__bootstrap_inner()
File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/schedv2.py", line 86, in run
self._execute_benchmark_run(br)
File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/schedv2.py", line 142, in _execute_benchmark_run
br.run()
File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/benchmark_run.py", line 106, in run
self.result = self.RunTest(self.machine)
File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/benchmark_run.py", line 210, in RunTest
self.profiler_args)
File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/suite_runner.py", line 62, in Run
self.PinGovernorExecutionFrequencies(machine, label.chromeos_root)
File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/suite_runner.py", line 121, in PinGovernorExecutionFrequencies
ret, 'Could not pin frequencies on machine: %s' % machine_name)
File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/cros_utils/logger.py", line 174, in LogFatalIf
self.LogFatal(msg)
File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/cros_utils/logger.py", line 157, in LogFatal
'\n'.join(traceback.format_stack()))
It is probably best to ignore the error.
,
May 3 2018
Basically, the error happens because this file can't be modified and that is generally because turbo driver is disabled. So, ignoring is the best way out here.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/065ab805e293e91904ba4d061cb66c6dfe657dad commit 065ab805e293e91904ba4d061cb66c6dfe657dad Author: Manoj Gupta <manojgupta@google.com> Date: Thu May 03 01:47:15 2018 crosperf: Ignore error when disabling turbo. Some boards do not permit changing tubo config /sys/devices/system/cpu/intel_pstate/no_turbo Ignore the error for now so that tests can continue. Also update some formatting suggested by tc_format. BUG= chromium:839125 TEST=No more errors. Change-Id: I3a709ea2638d783dd3a3ebf70eba8a6dbc4df53a Reviewed-on: https://chromium-review.googlesource.com/1040773 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> [modify] https://crrev.com/065ab805e293e91904ba4d061cb66c6dfe657dad/crosperf/suite_runner.py [modify] https://crrev.com/065ab805e293e91904ba4d061cb66c6dfe657dad/crosperf/suite_runner_unittest.py
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/c7e0520bf76fdea56408486c92aec51da718331c commit c7e0520bf76fdea56408486c92aec51da718331c Author: Manoj Gupta <manojgupta@google.com> Date: Fri May 04 10:02:18 2018 crosperf: Disable turbo only if enabled. Write to no_turbo file only if the field is set to 0. BUG= chromium:839125 TEST=No more errors Change-Id: If5de67606557c21107843837afd035cf32545475 Reviewed-on: https://chromium-review.googlesource.com/1042866 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/c7e0520bf76fdea56408486c92aec51da718331c/crosperf/suite_runner.py [modify] https://crrev.com/c7e0520bf76fdea56408486c92aec51da718331c/crosperf/suite_runner_unittest.py
,
May 6 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by llozano@chromium.org
, May 3 2018