Issue metadata
Sign in to add a comment
|
[MacViews-Browser] Regression: Omnibox Dropdown Results are 1px too far right |
||||||||||||||||||||||
Issue descriptionChrome Version: Canary 68.0.3417.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable MacViews-Browser in chrome://flags/#views-browser-windows (2) Type something into the Omnibox, so that the Dropdown appears What is the expected result? The Omnibox icons and text should be aligned with the icons and the text of the Dropdown. What happens instead? The Dropdown Results are 1px too far right. This is a regression. I did a manual bisect and this is the regression range: https://chromium.googlesource.com/chromium/src/+log/6db6869868929296eaca2c180f766b0f2476008b..8464dc3f1a74eb73d02685856ed3c7b922b7b73f Looks like https://chromium.googlesource.com/chromium/src/+/8464dc3f1a74eb73d02685856ed3c7b922b7b73f is the culprit CL. dschuyler@: Can you please take a look at this issue? Thanks in advance :-) Mehmet
,
May 3 2018
I was able to repro on Linux.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/678180e9e5aad1117b70a8e04db2dbc7ffac0f35 commit 678180e9e5aad1117b70a8e04db2dbc7ffac0f35 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu May 03 22:01:35 2018 [Omnibox] Remove extra padding on left in suggestions This CL removes an extra application of GetBorderThicknessDip(). It was being added in GetIconAlignmentOffset() and again outside of that call. Also cleans up a todo for the same topic. Bug: 839120 Change-Id: I7687903a879dd0f2e29dc7b9090052dc7ff57442 Reviewed-on: https://chromium-review.googlesource.com/1041208 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#555890} [modify] https://crrev.com/678180e9e5aad1117b70a8e04db2dbc7ffac0f35/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
,
May 3 2018
,
May 4 2018
Verified the fix on Mac 10.13.1 using Chrome version #68.0.3419.0 as per the comment #0. Attaching screen shot for reference. Observed that the Omnibox icons and text are aligned properly. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 68.0.3417.0 Thanks...!!
,
May 4 2018
Thank you dschuyler@ for the quick fix! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dschuyler@chromium.org
, May 3 2018