Perfetto: Avoid repeating data in the proto for each trace event |
||
Issue descriptionWe could cut down on trace size quite a lot by instead bundling several events for each top-level proto and just referencing a string table for the name/category, for example. The pid and tid will also be (mainly) identical for each TraceWriter, and the timestamps could have a minimum bound subtracted.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5660a9026ee524a5a06ce617a03ebd027f49eb9b commit 5660a9026ee524a5a06ce617a03ebd027f49eb9b Author: Oystein Eftevaag <oysteine@chromium.org> Date: Tue Sep 18 17:16:57 2018 Perfetto: Optimize proto usage This bundles multiple events into the same higher-level message and adds a string table implementation for frequently repeated strings, on a per-thread basis; specifically the event name, category name, and the name of its arguments. Requires https://android-review.googlesource.com/c/platform/external/perfetto/+/755290 to roll into //third_party/perfetto before landing. R=primiano@chromium.org,skyostil@chromium.org Bug: 839116 Change-Id: Id2681970db5b7ea5cadf0ee9bbcbbc1ebbba08c3 Reviewed-on: https://chromium-review.googlesource.com/1225306 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#592090} [modify] https://crrev.com/5660a9026ee524a5a06ce617a03ebd027f49eb9b/base/trace_event/trace_log.cc [modify] https://crrev.com/5660a9026ee524a5a06ce617a03ebd027f49eb9b/services/tracing/perfetto/json_trace_exporter.cc [modify] https://crrev.com/5660a9026ee524a5a06ce617a03ebd027f49eb9b/services/tracing/perfetto/json_trace_exporter_unittest.cc [modify] https://crrev.com/5660a9026ee524a5a06ce617a03ebd027f49eb9b/services/tracing/public/cpp/perfetto/trace_event_data_source.cc [modify] https://crrev.com/5660a9026ee524a5a06ce617a03ebd027f49eb9b/services/tracing/public/cpp/perfetto/trace_event_data_source_unittest.cc
,
Sep 18
|
||
►
Sign in to add a comment |
||
Comment 1 by benhenry@chromium.org
, Aug 3