New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839114 link

Starred by 1 user
Status: Fixed
Owner:
mlippautz@chromium.org
Closed: May 2018
Cc:
█ nednguyen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocking:
issue 757440



Sign in to add a comment

blink_heap_unittests failing on chromium.memory/Android CFI

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 2 2018 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@chromium.org

blink_heap_unittests failing on chromium.memory/Android CFI

Builders failed on: 
- Android CFI: 
  https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1940e0ce70651ca8cb36787ed0a96ace34eace3

commit b1940e0ce70651ca8cb36787ed0a96ace34eace3
Author: Ned Nguyen <nednguyen@google.com>
Date: Wed May 02 20:49:12 2018

Revert "[oilpan] Enable incremental marking buildflag"

This reverts commit d8a31d453aaa429829d6ba183f94b5ba016768bd.

Reason for revert: suspect breaking blink_heap_unittests

BUG: chromium:839114 

Original change's description:
> [oilpan] Enable incremental marking buildflag
> 
> Includes incremental garbage collection infrastructure in regular
> builds. Does not enable incremental marking at runtime!
> 
> This CL may cause throughput regressions and is an attempt
> to collect a broad range of potential performance issues.
> 
> Bug:  chromium:757440 
> Change-Id: Ie7b75f8d96f9230400beed1a3258e45e0ca742ed
> Reviewed-on: https://chromium-review.googlesource.com/980753
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555449}

TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org

Change-Id: I1d1cd812dcf24a9a87ad6100658e4c18979f29bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:757440 
Reviewed-on: https://chromium-review.googlesource.com/1040688
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#555504}
[modify] https://crrev.com/b1940e0ce70651ca8cb36787ed0a96ace34eace3/third_party/blink/renderer/platform/heap/BUILD.gn

Comment 2 by nednguyen@chromium.org, May 2 2018

Owner: mlippautz@chromium.org
Status: Assigned (was: Available)

Comment 3 by nednguyen@chromium.org, May 2 2018 

 Issue 839113  has been merged into this issue.

Comment 4 by mlippautz@chromium.org, May 3 2018

Blocking: 757440
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6524551518762533169e817cf3efe47eb4cbbd1a

commit 6524551518762533169e817cf3efe47eb4cbbd1a
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Thu May 03 09:51:34 2018

[oilpan] Fix CFI in incremental marking tests

Bug:  chromium:839114 ,  chromium:757440 
Change-Id: I9784179f8af19739a8c4398e3deea04611e12b09
Reviewed-on: https://chromium-review.googlesource.com/1041825
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555684}
[modify] https://crrev.com/6524551518762533169e817cf3efe47eb4cbbd1a/third_party/blink/renderer/platform/heap/incremental_marking_test.cc

Comment 6 by mlippautz@chromium.org, May 3 2018

Status: Fixed (was: Started)
►

Sign in to add a comment