HostIsCIBuilder doesn't detect swarming builders correctly. |
|||
Issue descriptionHostIsCIBuilder is used to confirm if we are on a real live builder, based on the host name. It doesn't know about swarming builder names.
,
May 14 2018
We could have puppet create a file that we check in the function instead, but that increases our puppet dependency instead of decreasing it. This function was originally just a sanity check on users misusing cbuildbot locally. I'd prefer to remove it and instead depend on users having/not having the correct credentials to do whatever is relevant. However, the method has been misused to control some testing since then and that would need to be cleaned up.
,
Jun 15 2018
Perhaps it's better to remove this method. It's only used in a few places, most of which seem to be doing the wrong thing anyway.
,
Jun 16 2018
,
Jun 19 2018
I was mistaken, it DOES understand our GCE builders. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jclinton@chromium.org
, May 11 2018