New issue
Advanced search Search tips

Issue 839097 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 853391



Sign in to add a comment

HostIsCIBuilder doesn't detect swarming builders correctly.

Project Member Reported by dgarr...@chromium.org, May 2 2018

Issue description

HostIsCIBuilder is used to confirm if we are on a real live builder, based on the host name.

It doesn't know about swarming builder names.
 
Can we use a Puppet filename that would only exist on a Swarming host instead? Or is there a Recipe API for this?
We could have puppet create a file that we check in the function instead, but that increases our puppet dependency instead of decreasing it.

This function was originally just a sanity check on users misusing cbuildbot locally. I'd prefer to remove it and instead depend on users having/not having the correct credentials to do whatever is relevant.

However, the method has been misused to control some testing since then and that would need to be cleaned up.

Perhaps it's better to remove this method. It's only used in a few places, most of which seem to be doing the wrong thing anyway.
Blockedon: 853391
Status: WontFix (was: Assigned)
I was mistaken, it DOES understand our GCE builders.

Sign in to add a comment