New issue
Advanced search Search tips

Issue 839084 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Mac
Pri: 3
Type: Feature

Blocked on: View detail
issue 839086
issue 875367
issue 886918
issue 886943
issue 888558
issue 900603

Blocking:
issue 880300
issue 880455
issue 883521
issue 883524



Sign in to add a comment

Perfetto: Enable by default for tracing

Project Member Reported by oysteine@chromium.org, May 2 2018

Issue description

Once we reach feature parity with TraceLog, Perfetto should be used by default when tracing is enabled.

 
Blockedon: 839086
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/17ea340ea40000

All of the runs failed. The most common error (10/20 runs) was:
SwarmingTaskError: The swarming task failed with state "BOT_DIED".
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1197f22ea40000

'unicode' object has no attribute 'get'
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11a2cc99a40000

All of the runs failed. The most common error (10/20 runs) was:
TimeoutException: Timed out while waiting 180s for HasReachedQuiescence.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14b1fb25a40000

All of the runs failed. The most common error (10/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16f305c1a40000

All of the runs failed. The most common error (10/20 runs) was:
BuildError: Build failed: BUILD_FAILURE
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/11e3abd5a40000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13f4c08ea40000

All of the runs failed. The most common error (15/20 runs) was:
TimeoutException: Timed out while waiting 180s for HasReachedQuiescence.
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/153f6eb6a40000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14c70b4da40000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14d778e0640000

'unicode' object has no attribute 'get'
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14bcf19fa40000
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49a68554cf5658d0cc3741a89db2fca1380a6fcc

commit 49a68554cf5658d0cc3741a89db2fca1380a6fcc
Author: Oystein Eftevaag <oysteine@google.com>
Date: Fri Aug 10 02:13:49 2018

Enable Perfetto usage for the loading perf tests.

This enables it for a limited subset of tests to catch any
regressions before enabling it for all perf tests, and will only
have an effect on Mac/Windows/Android platforms currently.

Bug: 839084
Change-Id: Ifcfcaefbbb3be177f9a5941031e48ead60f1fc77
Reviewed-on: https://chromium-review.googlesource.com/1169768
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#582017}
[modify] https://crrev.com/49a68554cf5658d0cc3741a89db2fca1380a6fcc/tools/perf/benchmarks/loading.py

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed

commit 32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed
Author: Oystein Eftevaag <oysteine@google.com>
Date: Thu Aug 23 02:11:42 2018

Enable Perfetto by default for all telemetry tests

This will use Perfetto instead of TraceLog for all
trace-based Telemetry tests running on Mac/Windows/Android.

R=nednguyen@google.com

Bug: 839084
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
Reviewed-on: https://chromium-review.googlesource.com/1176119
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#585368}
[modify] https://crrev.com/32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed/tools/perf/core/perf_benchmark.py

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af1ab709d3e40f69d46e01f068d02660893807b9

commit af1ab709d3e40f69d46e01f068d02660893807b9
Author: Hayato Ito <hayato@chromium.org>
Date: Thu Aug 23 07:45:58 2018

Revert "Enable Perfetto by default for all telemetry tests"

This reverts commit 32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed.

Reason for revert: [sheriff] This might be a culprit for consistent
failures [4 out of the last 4 builds] of telemetry_perf_unittests
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29

Started at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/73930

Original change's description:
> Enable Perfetto by default for all telemetry tests
> 
> This will use Perfetto instead of TraceLog for all
> trace-based Telemetry tests running on Mac/Windows/Android.
> 
> R=​nednguyen@google.com
> 
> Bug: 839084
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> Reviewed-on: https://chromium-review.googlesource.com/1176119
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#585368}

TBR=oysteine@chromium.org,skyostil@chromium.org,nednguyen@google.com

Change-Id: I162f26045f454c23eae1b99af5b3168c7f7b9e44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839084
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Reviewed-on: https://chromium-review.googlesource.com/1186301
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585423}
[modify] https://crrev.com/af1ab709d3e40f69d46e01f068d02660893807b9/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/af1ab709d3e40f69d46e01f068d02660893807b9/tools/perf/core/perf_benchmark.py

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df5976ffb0d467838a97f6fe39a208208615b064

commit df5976ffb0d467838a97f6fe39a208208615b064
Author: Oystein Eftevaag <oysteine@google.com>
Date: Fri Aug 24 19:26:49 2018

Reland "Enable Perfetto by default for all telemetry tests"

This is a reland of 32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed

The last Perfetto roll in https://chromium-review.googlesource.com/c/chromium/src/+/1188362
includes a fix for the bug that caused the revert.

Original change's description:
> Enable Perfetto by default for all telemetry tests
>
> This will use Perfetto instead of TraceLog for all
> trace-based Telemetry tests running on Mac/Windows/Android.
>
> R=nednguyen@google.com
>
> Bug: 839084
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> Reviewed-on: https://chromium-review.googlesource.com/1176119
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#585368}

TBR=nednguyen@google.com

Bug: 839084
Change-Id: Id416f7f81ae4f0056e80b678c32e608c2021d2ea
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Reviewed-on: https://chromium-review.googlesource.com/1188752
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585934}
[modify] https://crrev.com/df5976ffb0d467838a97f6fe39a208208615b064/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/df5976ffb0d467838a97f6fe39a208208615b064/tools/perf/core/perf_benchmark.py

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00bea4ec5efd575a09604b89fbf6123b14690fb6

commit 00bea4ec5efd575a09604b89fbf6123b14690fb6
Author: oysteine <oysteine@chromium.org>
Date: Wed Aug 29 01:46:18 2018

Revert "Reland "Enable Perfetto by default for all telemetry tests""

This reverts commit df5976ffb0d467838a97f6fe39a208208615b064.

Reason for revert: Reverting until the full reason for https://chromeperf.appspot.com/report?sid=b3b879254eada89bfdd6e650648489fccc991208d6ab046f4c7e87c10d6eb75e can be investigated.

Original change's description:
> Reland "Enable Perfetto by default for all telemetry tests"
> 
> This is a reland of 32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed
> 
> The last Perfetto roll in https://chromium-review.googlesource.com/c/chromium/src/+/1188362
> includes a fix for the bug that caused the revert.
> 
> Original change's description:
> > Enable Perfetto by default for all telemetry tests
> >
> > This will use Perfetto instead of TraceLog for all
> > trace-based Telemetry tests running on Mac/Windows/Android.
> >
> > R=nednguyen@google.com
> >
> > Bug: 839084
> > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> > Reviewed-on: https://chromium-review.googlesource.com/1176119
> > Commit-Queue: oysteine <oysteine@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Cr-Commit-Position: refs/heads/master@{#585368}
> 
> TBR=nednguyen@google.com
> 
> Bug: 839084
> Change-Id: Id416f7f81ae4f0056e80b678c32e608c2021d2ea
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Reviewed-on: https://chromium-review.googlesource.com/1188752
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585934}

TBR=oysteine@chromium.org,skyostil@chromium.org,nednguyen@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 839084
Change-Id: I9f46b30dc896a0d125af08aa6f4a834ec485c2cd
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Reviewed-on: https://chromium-review.googlesource.com/1194837
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586990}
[modify] https://crrev.com/00bea4ec5efd575a09604b89fbf6123b14690fb6/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/00bea4ec5efd575a09604b89fbf6123b14690fb6/tools/perf/core/perf_benchmark.py

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f374eff414ec0683aafbe2aae3fd405a4fcc221

commit 0f374eff414ec0683aafbe2aae3fd405a4fcc221
Author: Oystein Eftevaag <oysteine@google.com>
Date: Tue Sep 18 19:01:32 2018

Reland "Enable Perfetto by default for all telemetry tests"

This is a reland of 32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed

Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306

Original change's description:
> Enable Perfetto by default for all telemetry tests
>
> This will use Perfetto instead of TraceLog for all
> trace-based Telemetry tests running on Mac/Windows/Android.
>
> R=nednguyen@google.com
>
> Bug: 839084
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> Reviewed-on: https://chromium-review.googlesource.com/1176119
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#585368}

TBR=nednguyen@google.com

Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e
Reviewed-on: https://chromium-review.googlesource.com/1208955
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592127}
[modify] https://crrev.com/0f374eff414ec0683aafbe2aae3fd405a4fcc221/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/0f374eff414ec0683aafbe2aae3fd405a4fcc221/tools/perf/core/perf_benchmark.py

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f36de8b1bdc40bf31455b052ef63338072b093da

commit f36de8b1bdc40bf31455b052ef63338072b093da
Author: Egor Pasko <pasko@chromium.org>
Date: Wed Sep 19 15:11:26 2018

Revert "Reland "Enable Perfetto by default for all telemetry tests""

This reverts commit 0f374eff414ec0683aafbe2aae3fd405a4fcc221.

Reason for revert: http://crbug.com/886918

Original change's description:
> Reland "Enable Perfetto by default for all telemetry tests"
> 
> This is a reland of 32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed
> 
> Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306
> 
> Original change's description:
> > Enable Perfetto by default for all telemetry tests
> >
> > This will use Perfetto instead of TraceLog for all
> > trace-based Telemetry tests running on Mac/Windows/Android.
> >
> > R=nednguyen@google.com
> >
> > Bug: 839084
> > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> > Reviewed-on: https://chromium-review.googlesource.com/1176119
> > Commit-Queue: oysteine <oysteine@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Cr-Commit-Position: refs/heads/master@{#585368}
> 
> TBR=nednguyen@google.com
> 
> Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e
> Reviewed-on: https://chromium-review.googlesource.com/1208955
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592127}

TBR=sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com

Change-Id: I7e3984b90f8f53d1dface9459ea07d7383e7c6d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1233717
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592400}
[modify] https://crrev.com/f36de8b1bdc40bf31455b052ef63338072b093da/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/f36de8b1bdc40bf31455b052ef63338072b093da/tools/perf/core/perf_benchmark.py

Blockedon: 888558
Blockedon: 886918
Blockedon: 886943
Blocking: 883524
Blocking: 883521
Blocking: 880455
Blocking: 880300
Blockedon: 875367
Status: Assigned (was: Untriaged)
Project Member

Comment 40 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bb24369bef996b43b2d2711f0033ba472f779ea

commit 3bb24369bef996b43b2d2711f0033ba472f779ea
Author: Oystein Eftevaag <oysteine@chromium.org>
Date: Tue Oct 30 16:56:31 2018

Reland "Enable Perfetto by default for all telemetry tests"

This reverts commit f36de8b1bdc40bf31455b052ef63338072b093da.

Perf regressions addressed by:
https://chromium-review.googlesource.com/c/chromium/src/+/1263354
https://android-review.googlesource.com/c/platform/external/perfetto/+/799400



Original change's description:
> Revert "Reland "Enable Perfetto by default for all telemetry tests""
> 
> This reverts commit 0f374eff414ec0683aafbe2aae3fd405a4fcc221.
> 
> Reason for revert: http://crbug.com/886918
> 
> Original change's description:
> > Reland "Enable Perfetto by default for all telemetry tests"
> > 
> > This is a reland of 32c8ebbeeaee6dfdf46ae51d4c9c5b67dd465fed
> > 
> > Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306
> > 
> > Original change's description:
> > > Enable Perfetto by default for all telemetry tests
> > >
> > > This will use Perfetto instead of TraceLog for all
> > > trace-based Telemetry tests running on Mac/Windows/Android.
> > >
> > > R=nednguyen@google.com
> > >
> > > Bug: 839084
> > > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> > > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> > > Reviewed-on: https://chromium-review.googlesource.com/1176119
> > > Commit-Queue: oysteine <oysteine@chromium.org>
> > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#585368}
> > 
> > TBR=nednguyen@google.com
> > 
> > Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e
> > Reviewed-on: https://chromium-review.googlesource.com/1208955
> > Reviewed-by: oysteine <oysteine@chromium.org>
> > Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> > Commit-Queue: oysteine <oysteine@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#592127}
> 
> TBR=sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com
> 
> Change-Id: I7e3984b90f8f53d1dface9459ea07d7383e7c6d1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1233717
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Commit-Queue: Egor Pasko <pasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592400}

TBR=pasko@chromium.org,sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ic2b034d7d40ee65d14dab9ecfac914b744cd057d
Reviewed-on: https://chromium-review.googlesource.com/c/1307793
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603931}
[modify] https://crrev.com/3bb24369bef996b43b2d2711f0033ba472f779ea/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/3bb24369bef996b43b2d2711f0033ba472f779ea/tools/perf/core/perf_benchmark.py

Blockedon: 900603

Sign in to add a comment