New issue
Advanced search Search tips

Issue 839060 link

Starred by 1 user
Status: Fixed
Owner:
oysteine@chromium.org
Closed: May 2018
Cc:
primiano@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Perfetto: split 'complete' trace events into separate begin/end events.

Project Member Reported by oysteine@chromium.org, May 2 2018 
Currently scoped trace events work, as they rely on being able to look up an existing "complete" phase trace event and modify its duration, when a scoped class falls out of scope.
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39bd6b8f52311d20825587bfde178251b8e2845e

commit 39bd6b8f52311d20825587bfde178251b8e2845e
Author: Oystein Eftevaag <oysteine@google.com>
Date: Tue May 15 21:50:28 2018

Perfetto: split 'complete' trace events into separate begin/end events.

R=primiano@chromium.org
BUG= 839060 

Change-Id: I12fce3acecc060ade7ea98b1c1556f40dcc4a4c9
Reviewed-on: https://chromium-review.googlesource.com/1048565
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558846}
[modify] https://crrev.com/39bd6b8f52311d20825587bfde178251b8e2845e/base/trace_event/trace_log.cc
[modify] https://crrev.com/39bd6b8f52311d20825587bfde178251b8e2845e/services/tracing/public/cpp/perfetto/trace_event_data_source_unittest.cc

Comment 2 by oysteine@chromium.org, May 15 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment