Essentially adding this to the chrome_trace_event.proto: oneof { int32 int_arg1; string string_arg1; ... } oneof { int32 int_arg2; string string_arg2; ... }
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51fbfa5d10e3897d116abb32e64cc45b700e3057 commit 51fbfa5d10e3897d116abb32e64cc45b700e3057 Author: Oystein Eftevaag <oysteine@chromium.org> Date: Sat May 05 02:26:53 2018 Perfetto: Support POD trace event arguments Also: * Fixed two issues in TraceEventDataSourceTests causing tests to fail in some conditions. * Added more types to the trace_analyzer_test to handle more trace event fields. * Added base/trace_event/OWNERS as owners of base/test/trace_* Bug: 839058 Change-Id: I93aa40ef185aa149cf240e333838ca6c6339a53d Reviewed-on: https://chromium-review.googlesource.com/1041155 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#556294} [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/DEPS [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/base/test/OWNERS [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/base/test/trace_event_analyzer.cc [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/base/test/trace_event_analyzer.h [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/base/trace_event/trace_event_impl.h [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/services/tracing/perfetto/json_trace_exporter.cc [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/services/tracing/perfetto/json_trace_exporter_unittest.cc [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/services/tracing/public/cpp/perfetto/trace_event_data_source.cc [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/services/tracing/public/cpp/perfetto/trace_event_data_source.h [modify] https://crrev.com/51fbfa5d10e3897d116abb32e64cc45b700e3057/services/tracing/public/cpp/perfetto/trace_event_data_source_unittest.cc
Comment 1 Deleted