Potential event timestamp violation - WARNING:blink_event_util.cc(544) Event time not monotonic? |
||
Issue descriptionHitting this warning using a very recent build on Linux. Chromium 68.0.3416.0 (Developer Build) (64-bit) Revision 2e07490de8530fd90a7e8501367418f5eeb90ba8-refs/heads/master@{#554832} I To reproduce: 1. Open any page 2. Open devtools with touch emulation 3. Fling and then in the middle of fling scroll again /cc sahel@ in case this may be related to latest fling changes & dtapuska@ who added the original DCHECK.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd73314533313b565c566f2e956419ed42a47ca0 commit cd73314533313b565c566f2e956419ed42a47ca0 Author: Sahel Sharify <sahel@chromium.org> Date: Fri May 04 15:26:20 2018 Fixed timestamp for the GSB sent after deferred fling cancellation. When a GFC arrives, the fling controller doesn't cancel the active fling immediately. If the user starts a new scroll sequence while the fling cancellation is deferred, the controller suppresses the GSB/GSU events till either a new GFS arrives and the current fling gets boosted, or the controller decides that it is gonna cancel the fling and resume the new scroll sequence. To resume the new scroll sequence the controller sends a GSB since the original GSB of the sequence is suppressed. This cl changes the GSB event to have the timestamp of the last suppressed event instead of using the current time. This change is necessary to make sure that the monotonic time of a scroll sequence is not violated. Bug: 839051 Change-Id: I295de64deaad4b072ec69a1bbbc192f182577cf4 Reviewed-on: https://chromium-review.googlesource.com/1043017 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556063} [modify] https://crrev.com/cd73314533313b565c566f2e956419ed42a47ca0/content/browser/renderer_host/input/fling_controller.cc
,
May 4 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by sahel@chromium.org
, May 2 2018Status: Assigned (was: Untriaged)