New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839047 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Full screen android apps launched from external monitor are opened in primary display with wrong window size.

Project Member Reported by sdantul...@chromium.org, May 2 2018

Issue description

Google Chrome	67.0.3396.31 (Official Build) dev (64-bit)
Revision	d97ddce5b1d7f078ef2e120232503e8941080d7a-refs/branch-heads/3396@{#432}
Platform	10575.25.0 (Official Build) dev-channel eve

What steps will reproduce the problem?
(1) Connect chromebook to external monitor in extended display mode 
(2) Launch a full screen android app (Angry birds or Hill Climb Racing) from external monitor

What is the expected result?
App should be opened  in external monitor display

What happens instead?
App opens in primary display with window size as that of the external monitor display

 
Cc: skuhne@chromium.org
Owner: osh...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by osh...@chromium.org, May 14 2018

Owner: mukai@chromium.org
This is probably fixed by mukai@'s initial bounds fix? Mukai-san, can you confirm?

Comment 4 by mukai@chromium.org, May 14 2018

Should be fixed by crrev.com/550696 -- but it's not in M67?  Should we merge?

Comment 5 by osh...@chromium.org, May 14 2018

Labels: Merge-Request-67
I think so.
Project Member

Comment 6 by sheriffbot@chromium.org, May 14 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hi, this is a rather large number of lines into beta (though most appear to be for unittest).  Has this been extensively tested to ensure no unintended impact?  Low risk?

https://chromium-review.googlesource.com/c/chromium/src/+/1008402

Comment 8 by cindyb@chromium.org, May 17 2018

Covering for Kevin, have his requests in #7 been completed? Thanks!

Comment 9 by mukai@chromium.org, May 18 2018

The patch itself is actually small, the majority of the code is for adding the new test cases.
I think the risk is quite low, because 1) it is limited to the window control of ARC++ apps only, also affected only when an external display is connected, 2) the fix itself is small, and 3) the unit tests cover the testing scenarios.
Labels: -Merge-Review-67 Merge-Approved-67
Merge approved M67, thanks for the details.

Comment 11 by mukai@chromium.org, May 18 2018

Labels: -Merge-Approved-67 Merge-Merged
Status: Fixed (was: Assigned)
Merged as crrev.com/f88976b2017078c7799a370cc7e202977d1b0a76. Thanks.
Status: Verified (was: Fixed)
Verified on ChromeOS 10575.58.0, 67.0.3396.99 stable-channel eve

Sign in to add a comment