run_benchmarks --profiler=trace doesn't work |
|||
Issue descriptionExample: tools/perf/run_benchmark smoothness.sync_scroll.key_mobile_sites_smooth --story-filter=google_web_search --browser=android-chromium --profiler=trace Will throw an error. This is because the default is to trace; --profiler=trace is redundant here, and the code doesn't understand that. Also, the online documentation should be updated to say that --profiler=trace is not necessary.
,
May 2 2018
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/02bb4b7da4dbea61d40d2289bfb9d294616f76f3 commit 02bb4b7da4dbea61d40d2289bfb9d294616f76f3 Author: Nghia Nguyen <nednguyen@google.com> Date: Wed May 02 20:59:32 2018 Remove trace profiler Bug: chromium:839040 Change-Id: I90e8351f752837c3bb01762794373edf3c04ad34 TBR=perezju@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1040540 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> [delete] https://crrev.com/5b2cfb7fa5f197e561c81012a7cc17e5c19c84ec/telemetry/telemetry/internal/platform/profiler/trace_profiler.py [delete] https://crrev.com/5b2cfb7fa5f197e561c81012a7cc17e5c19c84ec/telemetry/telemetry/internal/platform/profiler/trace_profiler_unittest.py [modify] https://crrev.com/02bb4b7da4dbea61d40d2289bfb9d294616f76f3/telemetry/telemetry/page/page_run_end_to_end_unittest.py
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01be4bccc7dac6471312cc0ea8baacb3acbc36f1 commit 01be4bccc7dac6471312cc0ea8baacb3acbc36f1 Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 02 22:28:32 2018 Roll src/third_party/catapult/ 5b2cfb7fa..02bb4b7da (1 commit) https://chromium.googlesource.com/catapult.git/+log/5b2cfb7fa5f1..02bb4b7da4db $ git log 5b2cfb7fa..02bb4b7da --date=short --no-merges --format='%ad %ae %s' 2018-05-02 nednguyen Remove trace profiler Created with: roll-dep src/third_party/catapult BUG= chromium:839040 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ie9519e5232c398c781232594bab98de2daa2e794 Reviewed-on: https://chromium-review.googlesource.com/1040768 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555580} [modify] https://crrev.com/01be4bccc7dac6471312cc0ea8baacb3acbc36f1/DEPS
,
May 2 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nednguyen@chromium.org
, May 2 2018