New issue
Advanced search Search tips

Issue 839008 link

Starred by 4 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2018
Cc:
wangxianzhu@chromium.org
phanindra.mandapaka@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

mouse events not detected on secondary columns with position-relative inside max-height: xx overflow: scroll-y

Reported by brianrco...@gmail.com, May 2 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
1. Visit https://codepen.io/throttleup/pen/KRmLwL
2. Note upon clicking the first image "hi" is alerted
3. Clicking on any in subsequent columns does not trigger the "alert"

What is the expected behavior?
I would expect all images to trigger the mouse event

What went wrong?
The event did not fire

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 66.0.3359.139  Channel: stable
OS Version: OS X 10.13.2
Flash Version: 

I am fairly sure that this worked on 65, though I'm having trouble reproducing it in any versions on browserstack. Very strange, because I can reproduce it on multiple machines natively without issue.

Comment 1 by dtapu...@chromium.org, May 2 2018 

 Issue 839009  has been merged into this issue.

Comment 2 by krajshree@chromium.org, May 3 2018

Labels: Needs-Triage-M66

Comment 3 by viswa.karala@chromium.org, May 3 2018

Components: Blink>Paint
Labels: -Type-Bug -Pri-2 hasbisect-per-revision ReleaseBlock-Stable Target-67 Triaged-ET Target-66 M-66 FoundIn-66 FoundIn-67 FoundIn-68 RegressedIn-66 Target-68 OS-Windows Pri-1 Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 66.0.3359.139 and latest chrome 68.0.3418.0 using Windows-10, Mac 10.13.1 & Mac 10.13.3 hence providing Bisect Info
Note: Issue is not seen on Ubuntu 14.04
Bisect Info:
================
Good build: 66.0.3348.0
Bad build: 66.0.3349.0

You are probably looking for a change made after 536952 (known good), but no later than 536953 (first known bad).
https://chromium.googlesource.com/chromium/src/+log/6c5d2a4b76447457f77207430b1b9d124f43f753..5844f7146bca1e7c91e8f03de044ab408850d611
Reviewed-on: https://chromium-review.googlesource.com/912551

@Xianzhu Wang: Please confirm the issue and help in re-assigning if it is not related to your change.
Adding ReleaseBlock-Stable as it is seems a receent break, feel free to remove it if not applicable.

Thanks!

Comment 4 by wangxianzhu@chromium.org, May 3 2018

Labels: -M-66 M-67
What's the relationship between the M-XX and Target-XX labels? I didn't find documentation about it.

The fix will target M-67.

Comment 5 by wangxianzhu@chromium.org, May 3 2018

Labels: OS-Linux
Reproduced on Linux with --enable-prefer-compositing-to-lcd-text.

Comment 6 by wangxianzhu@chromium.org, May 3 2018

Labels: -Needs-Triage-M66
There seems something wrong with composited scrolling (which is enabled on high-dpi machines, or with --enable-prefer-compositing-to-lcd-text) of multicol contents.

For now, you can add "will-change: transform" in .list-container to workaround the issue.

Comment 7 by wangxianzhu@chromium.org, May 3 2018 

Reduced test case. Expected: two blue columns. Actual: Only one blue column.
composited-scroll-multicol-relative.html
292 bytes View Download

Comment 8 by wangxianzhu@chromium.org, May 3 2018 

Actually the test #c7 test case fails even before M66 because we don't allow fragmentation of composited layers. This may be fixed in SPv2.

The new test case is the real reduced test case for this bug. Click the blue and green blocks and see the output.
composited-under-multicol.html
430 bytes View Download
Project Member

Comment 9 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7771da317c4afcd8a89d27d33f33dd6bfea492e

commit c7771da317c4afcd8a89d27d33f33dd6bfea492e
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri May 04 04:34:14 2018

[PE] Skip fragment clip for composited layers under multicol

For now we don't allow fragmentation of composited layers, so they
should skip fragment clips.

Bug:  839008 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I33f5ef3e246c0b9bdf1f3e70798e1fd793ea1b58
Reviewed-on: https://chromium-review.googlesource.com/1042997
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555982}
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-translated-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fast/multicol/composited-layer-nested-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fast/multicol/composited-layer-will-change-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-translated-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fast/multicol/composited-layer-nested-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fast/multicol/composited-layer-will-change-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-translated-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/composited-layer-nested-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/composited-layer-will-change-expected.txt
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/c7771da317c4afcd8a89d27d33f33dd6bfea492e/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc

Comment 10 by wangxianzhu@chromium.org, May 4 2018

Labels: Merge-Request-67
Verified in canary 68.0.3419.0 on Mac.

Comment 11 by gov...@chromium.org, May 4 2018 

Thank you wangxianzhu@ for canary verification. How safe is the change to merge to M67 Beta?

Comment 12 by wangxianzhu@chromium.org, May 4 2018 

It's quite safe. The CL is small and just skips fragment clip of composited layers under multicol which is at the safe side.

Comment 13 by gov...@chromium.org, May 4 2018

Labels: -Merge-Request-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comments #11 and #12. Pls merge ASAP.

Also mark the bug as fixed after the merge if nothing else is pending. Thank you.

Comment 14 by wangxianzhu@chromium.org, May 4 2018

Status: Fixed (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, May 4 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/788915d3448d92a26d48cea16d8304ecf4de82c9

commit 788915d3448d92a26d48cea16d8304ecf4de82c9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri May 04 17:50:21 2018

[PE] Skip fragment clip for composited layers under multicol

For now we don't allow fragmentation of composited layers, so they
should skip fragment clips.

TBR=wangxianzhu@chromium.org

(cherry picked from commit c7771da317c4afcd8a89d27d33f33dd6bfea492e)

Bug:  839008 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I33f5ef3e246c0b9bdf1f3e70798e1fd793ea1b58
Reviewed-on: https://chromium-review.googlesource.com/1042997
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555982}
Reviewed-on: https://chromium-review.googlesource.com/1044536
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#480}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-translated-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fast/multicol/composited-layer-nested-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fast/multicol/composited-layer-will-change-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-translated-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fast/multicol/composited-layer-nested-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fast/multicol/composited-layer-will-change-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/composited-layer-multiple-fragments-translated-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/composited-layer-nested-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/fast/multicol/composited-layer-will-change-expected.txt
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/788915d3448d92a26d48cea16d8304ecf4de82c9/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc

Comment 16 by wangxianzhu@chromium.org, May 7 2018

Cc: phanindra.mandapaka@chromium.org wangxianzhu@chromium.org
 Issue 839873  has been merged into this issue.
Project Member

Comment 17 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/102c501d6159e39b1fa070e9685f3fae18afe5bd

commit 102c501d6159e39b1fa070e9685f3fae18afe5bd
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon May 07 16:30:17 2018

[M67] Fix compile of blink tests

The tests were written using some API not available in M67.

Bug: 840344,  839008 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I30966e9ee1fd75b0da3a2a5e49e2b5d85904759e
TBR: wangxianzhu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1047787
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#499}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/102c501d6159e39b1fa070e9685f3fae18afe5bd/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/102c501d6159e39b1fa070e9685f3fae18afe5bd/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer_test.cc

Comment 18 by dtapu...@chromium.org, May 24 2018 

 Issue 846285  has been merged into this issue.
►

Sign in to add a comment