New issue
Advanced search Search tips

Issue 839000 link

Starred by 3 users
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jul 9
Cc:
pkasting@chromium.org
malaykeshav@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Broken tab close button icons

Project Member Reported by afakhry@chromium.org, May 2 2018 
On ToT Chrome OS with --top-chrome-md=material-touch-optimized

The close tab icons are broken when they're hovered on. See attached video
hover_close_button-2018-05-02_10.55.30.mp4
53.3 KB View Download

Comment 1 by kylixrd@chromium.org, May 2 2018 

Ugh... Totally dropped the ball on that one. On it.
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a6fad3f84033e3b56460910835d71121c0b47dc

commit 2a6fad3f84033e3b56460910835d71121c0b47dc
Author: Allen Bauer <kylixrd@chromium.org>
Date: Wed May 02 21:19:47 2018

Fixed hover highlight for the tab close button

Bug:  839000 
Change-Id: I000a3aae3e5c9373baadc9f3c4d693e91ae07725
Reviewed-on: https://chromium-review.googlesource.com/1040671
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555545}
[modify] https://crrev.com/2a6fad3f84033e3b56460910835d71121c0b47dc/chrome/browser/ui/views/tabs/tab_close_button.cc

Comment 3 by kylixrd@chromium.org, Jul 9

Status: Fixed (was: Assigned)
►

Sign in to add a comment