New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838998 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 838996
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Combine two customized default wallpaper code paths into one

Project Member Reported by wzang@chromium.org, May 2 2018

Issue description

Background:
There're two ways for OEM's to specify customized default wallpapers:
1) Configured by cros-config, which results in the several switches. ([1])

2) From an online customization manifest. Currently it's only used by Basking device. ([2], [3])

Goal:
Investigate why there were two code paths in the first place (e.g. security implication related to OEM partition).

If possible, combine these into one. We should use an offline manifest instead of using code path 2) as is, because we must see the customized default wallpaper during OOBE without network, but 2) requires downloading the wallpaper first.

[1] https://chromium.googlesource.com/chromiumos/platform2/+/master/login_manager/chrome_setup.cc

[2]
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/customization/customization_wallpaper_downloader.h?dr=CSs

[3]
https://cs.corp.google.com/piper///depot/google3/googledata/html/external_content/gstatic/chrome/chromeos-customization/oem2-basking.json?q=wallpaper+file:%5E//depot/google3/googledata/html/external_content/gstatic/chrome/chromeos-customization/+package:%5Epiper$&dr=C&l=3
 

Comment 1 by wzang@chromium.org, May 2 2018

Mergedinto: 838996
Status: Duplicate (was: Assigned)
Sorry, accidentally clicked twice.

Sign in to add a comment