New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838997 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 759794
issue 784464



Sign in to add a comment

Find a better (or at least faster) way to get shared libraries

Project Member Reported by mmoroz@chromium.org, May 2 2018

Issue description

I've noticed that ldd approach landed in https://chromium-review.googlesource.com/c/chromium/src/+/1010464 takes a considerable amount of time when used with a large number of targets.

I think we can try:

1) find another solution that works faster? ldd seems to depend on size of the binary

2) do that in a multi-threaded way rather than looping through the binaries one by one

 
Owner: infe...@chromium.org
Status: Assigned (was: Untriaged)
Passing to Abhishek as per offline discussion, please feel free to bounce back.
Owner: ----
Status: Available (was: Assigned)
+ /chromium/src/tools/code_coverage/coverage.py chrome accessibility_unittests angle_unittests app_shell_unittests audio_unittests aura_unittests base_unittests battor_agent_unittests blink_common_unittests blink_heap_unittests blink_platform_unittests boringssl_crypto_tests boringssl_ssl_tests breakpad_unittests cacheinvalidation_unittests capture_unittests cast_unittests cc_blink_unittests cc_unittests components_browsertests components_unittests compositor_unittests content_browsertests content_unittests courgette_unittests crypto_unittests dbus_unittests device_unittests display_unittests events_unittests extensions_browsertests filesystem_service_unittests gcm_unit_tests gfx_unittests gin_unittests gl_unittests gn_unittests google_apis_unittests gpu_unittests headless_browsertests headless_unittests ipc_tests jingle_unittests keyboard_unittests leveldb_service_unittests libjingle_xmpp_unittests media_blink_unittests media_mojo_unittests media_service_unittests media_unittests midi_unittests nacl_loader_unittests native_theme_unittests net_unittests pdfium_unittests pdf_unittests ppapi_unittests printing_unittests remoting_unittests sandbox_linux_unittests service_manager_unittests services_unittests skia_unittests snapshot_unittests sql_unittests storage_unittests swiftshader_unittests sync_integration_tests traffic_annotation_auditor_unittests ui_base_unittests ui_touch_selection_unittests unit_tests url_unittests views_unittests viz_unittests vr_common_unittests webkit_unit_tests wm_unittests wtf_unittests browser_tests chrome_app_unittests interactive_ui_tests android_crazy_linker_zip_fuzzer angle_translator_fuzzer apdu_fuzzer appcache_manifest_parser_fuzzer audio_decoder_fuzzer audio_decoder_ilbc_fuzzer audio_decoder_isacfix_fuzzer audio_decoder_isac_fuzzer audio_decoder_isac_incoming_packet_fuzzer audio_decoder_opus_fuzzer audio_decoder_opus_redundant_fuzzer audio_processing_fuzzer ax_tree_fuzzer base64_decode_fuzzer base64_encode_fuzzer base_json_correctness_fuzzer base_json_reader_fuzzer base_json_string_escape_fuzzer bdict_fuzzer blink_harfbuzz_shaper_fuzzer blink_html_tokenizer_fuzzer blink_http_parsers_fuzzer blink_json_parser_fuzzer blink_png_decoder_fuzzer blink_text_codec_UTF_8_fuzzer blink_text_codec_WINDOWS_1252_fuzzer boringssl_bn_div_fuzzer boringssl_bn_mod_exp_fuzzer boringssl_cert_fuzzer boringssl_client_fuzzer boringssl_client_no_fuzzer_mode_fuzzer boringssl_dtls_client_fuzzer boringssl_dtls_server_fuzzer boringssl_pkcs8_fuzzer boringssl_privkey_fuzzer boringssl_read_pem_fuzzer boringssl_server_fuzzer boringssl_server_no_fuzzer_mode_fuzzer boringssl_session_fuzzer boringssl_spki_fuzzer boringssl_ssl_ctx_api_fuzzer brotli_fuzzer cast_message_fuzzer cbor_reader_fuzzer clear_site_data_fuzzer color_transform_fuzzer comfort_noise_decoder_fuzzer congestion_controller_feedback_fuzzer content_security_policy_fuzzer convert_woff2ttf_fuzzer css_parser_fast_paths_fuzzer css_parser_proto_fuzzer csv_reader_fuzzer ctap_response_fuzzer edid_parser_fuzzer expat_xml_parse_fuzzer feature_policy_fuzzer fido_ble_frames_fuzzer fido_hid_message_fuzzer fingerprint_fuzzer flatbuffers_verifier_fuzzer flexfec_header_reader_fuzzer flexfec_receiver_fuzzer flexfec_sender_fuzzer form_structure_fuzzer forward_error_correction_fuzzer gfx_png_image_fuzzer gn_parser_fuzzer gpu_angle_fuzzer gpu_angle_passthrough_fuzzer gpu_fuzzer gpu_swiftshader_fuzzer gurl_fuzzer h264_bitstream_parser_fuzzer h264_depacketizer_fuzzer harfbuzz_fuzzer hash_fuzzer hid_report_descriptor_fuzzer hit_test_manager_fuzzer hit_test_query_fuzzer html_preload_scanner_fuzzer hunspell_fuzzer icu_break_iterator_fuzzer icu_break_iterator_utf32_fuzzer icu_converter_fuzzer icu_number_format_fuzzer icu_ucasemap_fuzzer icu_unicode_string_codepage_create_fuzzer icu_uregex_open_fuzzer javascript_parser_proto_fuzzer language_detection_fuzzer libpng_progressive_read_fuzzer libpng_read_fuzzer libsrtp_fuzzer......remaining fuzzer

[2018-05-08 04:37:14,188 INFO] Finding shared libraries for targets (if any).
[2018-05-08 04:37:17,280 DEBUG] Found shared libraries (3): ['/chromium/src/out/coverage/./libmalloc_wrapper.so', '/chromium/src/out/coverage/swiftshader/libEGL.so', '/chromium/src/out/coverage/swiftshader/libGLESv2.so'].
[2018-05-08 04:37:17,281 INFO] Finished finding shared libraries for targets.

Only 3 minutes for ldd on all archives. looks like everything is already cached in memory. Will continue to keep an eye, but this is not a blocker for v1 launch.

Comment 3 by aarya@google.com, May 8 2018

Labels: -Pri-2 Pri-3
Confirmed not a blocker for sure.
Status: WontFix (was: Available)

Sign in to add a comment