Chrome crashes accessing Info page after closing all tabs. |
|||||
Issue description
Chrome Version: 68.0.3417.0 Canary
OS: Android 8.0.0 on Lenovo Daydream device
What steps will reproduce the problem?
(1) Launch Chrome from DD Home
(2) Use Overflow menu to "Close All Tabs"
Omnibox URL = about:blank
(3) Click Info icon on Omnibox
What is the expected result?
Either an Info page or nothing (disable button)
What happens instead?
Chrome crash.
,
May 14 2018
This also occurs on non-standalone devices. Just repro'd on a Galaxy S8+ with Chrome 68.0.3427.0. Crash ID: 452d67e11b58432f
,
May 14 2018
,
May 16 2018
Note that the fix I'm planning doesn't disable the button, it just renders a click useless. If we do launch tabs, then the UI will have the plumbing to selectively disable the button.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dd1eac5aa6f15eaf3c4bbe9f5a4f10a9ad0d08e commit 1dd1eac5aa6f15eaf3c4bbe9f5a4f10a9ad0d08e Author: Christopher Grant <cjgrant@chromium.org> Date: Thu May 17 17:03:20 2018 VR: Do not show a page info pop-up if there is no current tab If there's no tab, trying to show page info crashes. Because this is a fringe case, this fix simply makes the button do nothing, rather than binding visibility of the security icon to whether we have an active tab. Also, doing that is subject to race conditions, so we'd need this change anyway. BUG= 838995 R=asimjour Change-Id: Ia641655c7a375615ff695580409777f0808a2f16 Reviewed-on: https://chromium-review.googlesource.com/1062713 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#559575} [modify] https://crrev.com/1dd1eac5aa6f15eaf3c4bbe9f5a4f10a9ad0d08e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
May 23 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dbbrooks@chromium.org
, May 11 2018