New issue
Advanced search Search tips

Issue 838971 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Longpress should not get suppressed after Tap down suppression.

Project Member Reported by sahel@chromium.org, May 2 2018

Issue description

Longpress should get forwarded after a GFC followed by Tap down suppression.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2018

Comment 2 by sahel@chromium.org, May 2 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2845155ee07a5cead8c7e61f29fc17d894bd26c9

commit 2845155ee07a5cead8c7e61f29fc17d894bd26c9
Author: Sahel Sharify <sahel@chromium.org>
Date: Wed May 23 00:50:22 2018

Revert "Long press shouldn't get suppressed after tap down suppression."

This reverts commit a8a4a6f6a8e9b8e52da3897fc0995789c57ec113.

Reason for revert: This change is not needed anymore.

Original change's description:
> Long press shouldn't get suppressed after tap down suppression.
> 
> Bug:  838971 
> Change-Id: Ic296d7e5792ed38cc636b1f84d7d3d2e1ac229cb
> Reviewed-on: https://chromium-review.googlesource.com/1037424
> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555536}

TBR=dtapuska@chromium.org,sahel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  838971 
Change-Id: I09106b10fcfd2f2568c9716a28f3c620794e2482
Reviewed-on: https://chromium-review.googlesource.com/1062341
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560862}
[modify] https://crrev.com/2845155ee07a5cead8c7e61f29fc17d894bd26c9/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/2845155ee07a5cead8c7e61f29fc17d894bd26c9/content/browser/renderer_host/input/fling_controller_unittest.cc
[modify] https://crrev.com/2845155ee07a5cead8c7e61f29fc17d894bd26c9/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc

Sign in to add a comment