Client hints attached by Chrome may not be in the correct ABNF |
|||
Issue descriptionOn main frame navigations, Chrome may attach client hints to the request (if the server had requested for them in the past). For client hints, that have value < 1, the attached client hint may be of the format ".xx". e.g., dpr attached to main frame navigation may have a value of ".77" instead of "0.77". This is not spec-compliant as the spec requires the value to follow the grammar: 1*DIGIT [ "." 1*DIGIT See http://httpwg.org/http-extensions/client-hints.html#dpr.
,
May 4 2018
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62efba10f580439cad11b5e828e5b464097ce40d commit 62efba10f580439cad11b5e828e5b464097ce40d Author: Tarun Bansal <tbansal@chromium.org> Date: Fri May 04 22:58:35 2018 Ensure client hints follow the grammar specified in the spec If the client hint header value is a double with magnitude < 1, prepend at least one character (0 in this case) before the period. Change-Id: Ia7197d5efc3e4eba44f8d5d32ccb3ba474ecf80e Bug: 838958 Reviewed-on: https://chromium-review.googlesource.com/1038738 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#556233} [modify] https://crrev.com/62efba10f580439cad11b5e828e5b464097ce40d/chrome/browser/client_hints/client_hints.cc [modify] https://crrev.com/62efba10f580439cad11b5e828e5b464097ce40d/chrome/browser/client_hints/client_hints_browsertest.cc
,
May 5 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted