Migrate dom distiller to Network Service |
||||||||||
Issue descriptioncomponents/dom_distiller/ currently uses content::BrowserContext::GetDefaultStoragePartition(profile)->GetURLRequestContext() and URLFetcher to make network requests. With Network Service, StoragePartition::GetURLRequestContext() will be soon unsupported. We need to migrate dom_distiller to using StoragePartition::GetNetworkContext() and URLLoader APIs to make network requests.
,
May 7 2018
Tommy, any interest in migrating this code?
,
May 8 2018
An example CL to migrate URLFetcher to SimpleURLLoader is https://chromium-review.googlesource.com/c/chromium/src/+/986675. Let me know if you have any questions. Thanks!
,
May 15 2018
,
May 15 2018
,
May 18 2018
,
Jun 6 2018
wychen: Could you take this on?
,
Jun 20 2018
,
Jul 16
wychen@, if you do not mind, I would like to get started on this one. feel free to let me know if you have it WIP already.
,
Jul 16
I don't have a WIP CL. Thanks for taking this one.
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adcaa34b80df0607efcd0f5332970d8acf86f182 commit adcaa34b80df0607efcd0f5332970d8acf86f182 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Jul 18 14:36:47 2018 Migrate dom distiller to SimpleURLLoader BUG= 838955 TBR=noyau@chromium.org (one line in ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc) Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I050dbe74fc7ccd7b7811a5532abc931fda189177 Reviewed-on: https://chromium-review.googlesource.com/1140973 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576047} [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/chrome/browser/dom_distiller/dom_distiller_service_factory.cc [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/components/dom_distiller/DEPS [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/components/dom_distiller/core/BUILD.gn [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/components/dom_distiller/core/distiller_unittest.cc [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/components/dom_distiller/core/distiller_url_fetcher.cc [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/components/dom_distiller/core/distiller_url_fetcher.h [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/components/dom_distiller/core/distiller_url_fetcher_unittest.cc [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/components/dom_distiller/standalone/content_extractor_browsertest.cc [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/ios/chrome/browser/reading_list/reading_list_download_service_factory.cc [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/ios/chrome/browser/reading_list/url_downloader.cc [modify] https://crrev.com/adcaa34b80df0607efcd0f5332970d8acf86f182/ios/chrome/browser/reading_list/url_downloader.h
,
Jul 18
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by xunji...@chromium.org
, May 2 2018