New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 838954 link

Starred by 2 users
Status: Fixed
Owner:
█ ijamardo@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
█ lincolnfrog@chromium.org
█ johnpallett@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Check if ARCore is installed and if it is the correct version. If not, request install.

Project Member Reported by ijamardo@chromium.org, May 2 2018 
ARCore is distributed in the form of an external APK that needs to be installed on the device so the ARCore SDK can make use of it (it is an Android service). The Chromium ARCore integration should check if the APK is present and if the version of ARCore Chromium supports is the correct one compared to the installed one. If these preconditions do not apply, Chromium should request the installation/update of the ARCore APK to the Google Play Store.

Comment 1 by ddorwin@chromium.org, May 17 2018

Components: Internals>VR

Comment 2 by ddorwin@chromium.org, Jun 8 2018

Blockedon: 837999
Cc: lincolnfrog@chromium.org johnpallett@chromium.org
Labels: -Type-Bug Target-70 OS-Android Type-Task
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/703de90c00513e3800a9524fd9338424fdd85c2a

commit 703de90c00513e3800a9524fd9338424fdd85c2a
Author: Iker Jamardo <ijamardo@chromium.org>
Date: Tue Jun 12 21:55:15 2018

Check if ARCore is installed or needs update.

When requesting a session and after the camera permission is confirmed
to have been granted, check if ARCore is installed and if the version
used in Chromium is compatible with it. If ARCore is not installed
or an update is required, a prompt will be shown.

Bug:  838954 
Change-Id: I35ae39041e7958743bba9cc1c71f5af817bf4240
Reviewed-on: https://chromium-review.googlesource.com/1074494
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Iker Jamardo <ijamardo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566589}
[modify] https://crrev.com/703de90c00513e3800a9524fd9338424fdd85c2a/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
[modify] https://crrev.com/703de90c00513e3800a9524fd9338424fdd85c2a/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/703de90c00513e3800a9524fd9338424fdd85c2a/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/703de90c00513e3800a9524fd9338424fdd85c2a/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/703de90c00513e3800a9524fd9338424fdd85c2a/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[modify] https://crrev.com/703de90c00513e3800a9524fd9338424fdd85c2a/chrome/browser/android/vr/arcore_device/arcore_java_utils.h
[modify] https://crrev.com/703de90c00513e3800a9524fd9338424fdd85c2a/components/infobars/core/infobar_delegate.h
[modify] https://crrev.com/703de90c00513e3800a9524fd9338424fdd85c2a/tools/metrics/histograms/enums.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91a0deb09438f0e980fb5cdf2a71faf48643cd87

commit 91a0deb09438f0e980fb5cdf2a71faf48643cd87
Author: Nate Fischer <ntfschr@chromium.org>
Date: Wed Jun 13 00:09:21 2018

Revert "Check if ARCore is installed or needs update."

This reverts commit 703de90c00513e3800a9524fd9338424fdd85c2a.

Reason for revert: lint errors (http://crbug.com/852189)

Original change's description:
> Check if ARCore is installed or needs update.
> 
> When requesting a session and after the camera permission is confirmed
> to have been granted, check if ARCore is installed and if the version
> used in Chromium is compatible with it. If ARCore is not installed
> or an update is required, a prompt will be shown.
> 
> Bug:  838954 
> Change-Id: I35ae39041e7958743bba9cc1c71f5af817bf4240
> Reviewed-on: https://chromium-review.googlesource.com/1074494
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Commit-Queue: Iker Jamardo <ijamardo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566589}

TBR=ddorwin@chromium.org,vollick@chromium.org,pkasting@chromium.org,yfriedman@chromium.org,bshe@chromium.org,mthiesse@chromium.org,estade@chromium.org,twellington@chromium.org,agrieve@chromium.org,klausw@chromium.org,billorr@chromium.org,lincolnfrog@chromium.org,ijamardo@chromium.org

Change-Id: I1f88a1de68d4929a842a4c7bf95aa90a7f48bcba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  838954 
Bug: 852189
Reviewed-on: https://chromium-review.googlesource.com/1098335
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566635}
[modify] https://crrev.com/91a0deb09438f0e980fb5cdf2a71faf48643cd87/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
[modify] https://crrev.com/91a0deb09438f0e980fb5cdf2a71faf48643cd87/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/91a0deb09438f0e980fb5cdf2a71faf48643cd87/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/91a0deb09438f0e980fb5cdf2a71faf48643cd87/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/91a0deb09438f0e980fb5cdf2a71faf48643cd87/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[modify] https://crrev.com/91a0deb09438f0e980fb5cdf2a71faf48643cd87/chrome/browser/android/vr/arcore_device/arcore_java_utils.h
[modify] https://crrev.com/91a0deb09438f0e980fb5cdf2a71faf48643cd87/components/infobars/core/infobar_delegate.h
[modify] https://crrev.com/91a0deb09438f0e980fb5cdf2a71faf48643cd87/tools/metrics/histograms/enums.xml
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f8b47da922df5359de161f1cb5e926e63c339bb

commit 7f8b47da922df5359de161f1cb5e926e63c339bb
Author: Iker Jamardo <ijamardo@chromium.org>
Date: Sat Jun 16 15:49:12 2018

Reland "Check if ARCore is installed or needs update."

This reverts commit 91a0deb09438f0e980fb5cdf2a71faf48643cd87.

Reason for revert: Added conditional checks for strings.

Original change's description:
> Revert "Check if ARCore is installed or needs update."
>
> This reverts commit 703de90c00513e3800a9524fd9338424fdd85c2a.
>
> Reason for revert: lint errors (http://crbug.com/852189)
>
> Original change's description:
> > Check if ARCore is installed or needs update.
> >
> > When requesting a session and after the camera permission is confirmed
> > to have been granted, check if ARCore is installed and if the version
> > used in Chromium is compatible with it. If ARCore is not installed
> > or an update is required, a prompt will be shown.
> >
> > Bug:  838954 
> > Change-Id: I35ae39041e7958743bba9cc1c71f5af817bf4240
> > Reviewed-on: https://chromium-review.googlesource.com/1074494
> > Reviewed-by: Theresa <twellington@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Reviewed-by: Evan Stade <estade@chromium.org>
> > Reviewed-by: Klaus Weidner <klausw@chromium.org>
> > Commit-Queue: Iker Jamardo <ijamardo@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#566589}
>
> TBR=ddorwin@chromium.org,vollick@chromium.org,pkasting@chromium.org,yfriedman@chromium.org,bshe@chromium.org,mthiesse@chromium.org,estade@chromium.org,twellington@chromium.org,agrieve@chromium.org,klausw@chromium.org,billorr@chromium.org,lincolnfrog@chromium.org,ijamardo@chromium.org
>
> Change-Id: I1f88a1de68d4929a842a4c7bf95aa90a7f48bcba
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  838954 
> Bug: 852189
> Reviewed-on: https://chromium-review.googlesource.com/1098335
> Reviewed-by: Nate Fischer <ntfschr@chromium.org>
> Commit-Queue: Nate Fischer <ntfschr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566635}


Bug:  838954 , 852189
Change-Id: I33fd3d06d749e3f522e3eb4403462112f67295f3
Reviewed-on: https://chromium-review.googlesource.com/1100487
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Iker Jamardo <ijamardo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567890}
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/build/config/android/rules.gni
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/chrome/android/BUILD.gn
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/chrome/browser/android/vr/arcore_device/arcore_java_utils.h
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/chrome/common/features.gni
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/components/infobars/core/infobar_delegate.h
[modify] https://crrev.com/7f8b47da922df5359de161f1cb5e926e63c339bb/tools/metrics/histograms/enums.xml

Comment 6 by ijamardo@chromium.org, Jun 18 2018

Description: Show this description

Comment 7 by ijamardo@chromium.org, Jun 18 2018

Summary: Check if ARCore is installed and if it is the correct version. If not, request install. (was: The check if ARCore is supported and if the ARCore APK is installed and the correct version should be done by the ARCoreSDK)

Comment 8 by ddorwin@chromium.org, Jun 18 2018

Blockedon: -837999

Comment 9 by ijamardo@chromium.org, Jun 18 2018

Status: Fixed (was: Assigned)

Comment 10 by btebbs@chromium.org, Jul 4

Components: Internals>XR
►

Sign in to add a comment