VR omnibox size changes slightly when toggling between an empty and non-empty text field |
|||||||
Issue descriptionAlso, the overall size of the omnibox is slightly too large, and it's width constant should be changed to match the current UX spec.
,
May 2 2018
,
May 2 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 3 2018
Please verify in canary
,
May 8 2018
If you no longer intend to merge this issue into M67 please remove the merge review label.
,
May 8 2018
I do intend to merge - when the "test in canary" request was issued, a Canary with the CL had not yet been pushed. I'll check again today.
,
May 8 2018
Verified in Canary 68.0.3420
,
May 8 2018
I hope this is only related to VR users.
,
May 9 2018
This applies to the VR UI - it cannot impact anything outside VR.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a076b9df1296c583fe572f61a3e6b51c8cac00a commit 4a076b9df1296c583fe572f61a3e6b51c8cac00a Author: Christopher Grant <cjgrant@chromium.org> Date: Wed May 09 13:10:14 2018 VR: Fix omnibox sizing when non-empty and incognito. Also, tweak the overall width to match the current spec. BUG= 838939 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4727da0c669b6b59add3ce96e3b0b1276c4050e6 Reviewed-on: https://chromium-review.googlesource.com/1039873 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#555441}(cherry picked from commit b1e4ef59e0be1d0306e2f9761d5dda84f5c6291f) Reviewed-on: https://chromium-review.googlesource.com/1051870 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#533} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/4a076b9df1296c583fe572f61a3e6b51c8cac00a/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/4a076b9df1296c583fe572f61a3e6b51c8cac00a/chrome/browser/vr/ui_scene_creator.cc
,
May 9 2018
,
May 9 2018
To manually verify this: Enter incognito, open the omnibox, and type text. The width of the omnibox should not change as suggestions appear above the text field. Previously, the field would grow ever so slightly.
,
May 14 2018
Verified on build 68.0.3427.0 Canary. Looks good. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, May 2 2018