Implement UI to show open tabs.
Issue 693163 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed7e354871fabc4ffc55bde1ffc0c235931d91e9 commit ed7e354871fabc4ffc55bde1ffc0c235931d91e9 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon May 07 20:16:19 2018 [vr] Add PagedGridLayout and PagedScrollView Big thanks to vollick@ because most of this is based on his WIP CL from last year (crrev/v/590180). Bug: 838937 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4f6b00ef159d4acf3afdaf945947f2c71457c3b2 Reviewed-on: https://chromium-review.googlesource.com/1043284 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556548} [modify] https://crrev.com/ed7e354871fabc4ffc55bde1ffc0c235931d91e9/chrome/browser/vr/BUILD.gn [add] https://crrev.com/ed7e354871fabc4ffc55bde1ffc0c235931d91e9/chrome/browser/vr/elements/paged_grid_layout.cc [add] https://crrev.com/ed7e354871fabc4ffc55bde1ffc0c235931d91e9/chrome/browser/vr/elements/paged_grid_layout.h [add] https://crrev.com/ed7e354871fabc4ffc55bde1ffc0c235931d91e9/chrome/browser/vr/elements/paged_grid_layout_unittest.cc [add] https://crrev.com/ed7e354871fabc4ffc55bde1ffc0c235931d91e9/chrome/browser/vr/elements/paged_scroll_view.cc [add] https://crrev.com/ed7e354871fabc4ffc55bde1ffc0c235931d91e9/chrome/browser/vr/elements/paged_scroll_view.h [modify] https://crrev.com/ed7e354871fabc4ffc55bde1ffc0c235931d91e9/chrome/browser/vr/target_property.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df2bf01727e1116b7d6609d3b983d180ee1fe1e3 commit df2bf01727e1116b7d6609d3b983d180ee1fe1e3 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue May 08 01:02:13 2018 [vr] Add tabs overview (disabled currently) Bug: 838937 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I2977e405cef9fb1a74063900fb98c046aa04bf80 Reviewed-on: https://chromium-review.googlesource.com/1044765 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#556632} [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/browser_ui_interface.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/model/color_scheme.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/model/model.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/model/model.h [add] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/model/tab_model.cc [add] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/model/tab_model.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/model/ui_mode.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/test/mock_browser_ui_interface.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/ui.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/ui.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/ui_scene.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/ui_scene_creator.h [modify] https://crrev.com/df2bf01727e1116b7d6609d3b983d180ee1fe1e3/chrome/browser/vr/ui_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db04546618220592d6759dd17aaa06688987547c commit db04546618220592d6759dd17aaa06688987547c Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri May 11 14:46:34 2018 [vr] Add UI to switch between regular and incognito in tabs view Bug: 840511 , 838937 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4b688d12e0f08ce265c5796df2d96d473b4591c8 Reviewed-on: https://chromium-review.googlesource.com/1048831 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557879} [modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/app/generated_resources.grd [modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/model/color_scheme.h [modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/model/model.h [modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/ui.cc [modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/db04546618220592d6759dd17aaa06688987547c/chrome/browser/vr/ui_scene_creator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0ec23f6e4aea1079419a967a3f5716756d2624 commit 8f0ec23f6e4aea1079419a967a3f5716756d2624 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri May 11 18:58:49 2018 [vr] Add ability to close tab in tabs view Adds a button to close tab and plumbing to send the close request to Java. Bug: 838937 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I45d6d8c3c66674bc472a17335a6e02195f8a23b8 Reviewed-on: https://chromium-review.googlesource.com/1050794 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557964} [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/browser_ui_interface.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/elements/shadow.cc [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/elements/shadow.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/elements/ui_element_type.cc [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/elements/ui_element_type.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/test/mock_browser_ui_interface.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/test/mock_ui_browser_interface.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/ui.cc [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/ui.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/ui_browser_interface.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/8f0ec23f6e4aea1079419a967a3f5716756d2624/chrome/browser/vr/ui_unittest.cc
Comment 1 by tiborg@chromium.org
, May 2 2018