New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838925 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

refactor content_input_delegate and vr_dialog so the common code can be shared in a more clear way

Project Member Reported by bshe@chromium.org, May 2 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41db7d269b73979eaf2bbc24e457319da7c74b15

commit 41db7d269b73979eaf2bbc24e457319da7c74b15
Author: Biao She <bshe@chromium.org>
Date: Mon May 14 14:08:33 2018

Split ContentInputDelegate to PlatformUiInputDelegate and ContentInputDelegate

PlatformUiInputDelegate is used by PlatformUiElement and ContentInputDelegate is
used by ContentElement.
ContentInputDelegate is a PlatformUiInputDelegate. It has extra responsiblity to
handle focus and text input in web content. PlatformUiInputDelegate generates/sends
WebInputEvent to platform UI (i.e. view on Android platform).

Bug:  838925 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I18c90b656e5e0f341666f4eb22d5a5ac2252c2ef
Reviewed-on: https://chromium-review.googlesource.com/1050809
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558293}
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/android/vr/BUILD.gn
[delete] https://crrev.com/1354f55662a39b662ac962607663d0e8d66d696a/chrome/browser/android/vr/vr_dialog.cc
[delete] https://crrev.com/1354f55662a39b662ac962607663d0e8d66d696a/chrome/browser/android/vr/vr_dialog.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/android/vr/vr_input_connection.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/content_input_delegate.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/elements/content_element.cc
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/elements/content_element.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/elements/content_element_unittest.cc
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/elements/platform_ui_element.cc
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/elements/platform_ui_element.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/model/hosted_platform_ui.h
[add] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/platform_input_handler.h
[add] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/platform_ui_input_delegate.cc
[add] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/platform_ui_input_delegate.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/test/mock_content_input_delegate.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/ui.cc
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/ui.h
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/41db7d269b73979eaf2bbc24e457319da7c74b15/chrome/browser/vr/ui_scene_creator.cc

Comment 2 by bshe@chromium.org, May 24 2018

Status: Fixed (was: Assigned)

Sign in to add a comment