Autofill: testTapInputFieldShowsKeyboardAccessory flaky |
||||
Issue descriptionWill disable test.
,
May 2 2018
Failure stacktrace before it gets lost in the mists of buildbot (from https://storage.cloud.google.com/chromium-result-details/html/chrome_public_test_apk_KitKat%20Phone%20Tester%20%28dbg%29_5888_2018_05_02_T15_13_26-UTC): java.lang.AssertionError: Values did not match. Expected: true, actual: false at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:93) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:172) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:194) at org.chromium.chrome.browser.autofill.AutofillKeyboardAccessoryIntegrationTest.testTapInputFieldShowsKeyboardAccessory(AutofillKeyboardAccessoryIntegrationTest.java:135) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:114) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:201) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:43) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:183) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:120) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
May 3 2018
Thanks for disabling it! I will take a look - it's likely to get better with https://crrev.com/c/1028230.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc92f9dbb51a25f4e85f65b38b9b99218294c3a8 commit dc92f9dbb51a25f4e85f65b38b9b99218294c3a8 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Tue May 08 15:06:21 2018 Reactivate deflaked keyboard accessory tests After having landed https://crrev.com/c/1028230, the problems of the linked bug seem to have gone (as assumed). I removed the Disabling and RetryOnFailure annotations to test on 3 devices (one physical, two emulator with different screen sizes and OS) and couldn't find a single broken test. Edit: I changed the font size recently (not finally) which seems to bother some bots - unrelated from the filed bug. Changed that back. This CL now reenables all the tests but keeps the RetryOnFailure annotation. That way, I can test whether the tests start failing on some bots again without making the sheriffs life harder. If the bots don't notice any flakiness, I will remove the RetryOnFailure annotation as well and mark the linked bug fixed. Bug: 838922 Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4 Reviewed-on: https://chromium-review.googlesource.com/1044371 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#556798} [modify] https://crrev.com/dc92f9dbb51a25f4e85f65b38b9b99218294c3a8/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/dc92f9dbb51a25f4e85f65b38b9b99218294c3a8/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
,
May 9 2018
Looks like the tests still fail on this one bot: https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Tablet%20Tester/12646
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7da4ea6da89371004a20ab2e157d8ba6aabd57b3 commit 7da4ea6da89371004a20ab2e157d8ba6aabd57b3 Author: agrieve <agrieve@chromium.org> Date: Wed May 09 01:28:16 2018 Revert "Reactivate deflaked keyboard accessory tests" This reverts commit dc92f9dbb51a25f4e85f65b38b9b99218294c3a8. Reason for revert: Tests consistently fail on https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Tablet%20Tester/12646 Original change's description: > Reactivate deflaked keyboard accessory tests > > After having landed https://crrev.com/c/1028230, the problems of the > linked bug seem to have gone (as assumed). > > I removed the Disabling and RetryOnFailure annotations to test on 3 > devices (one physical, two emulator with different screen sizes and OS) > and couldn't find a single broken test. > Edit: I changed the font size recently (not finally) which seems to > bother some bots - unrelated from the filed bug. Changed that back. > > This CL now reenables all the tests but keeps the RetryOnFailure > annotation. That way, I can test whether the tests start failing on > some bots again without making the sheriffs life harder. > If the bots don't notice any flakiness, I will remove the > RetryOnFailure annotation as well and mark the linked bug fixed. > > Bug: 838922 > Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4 > Reviewed-on: https://chromium-review.googlesource.com/1044371 > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556798} TBR=bauerb@chromium.org,fhorschig@chromium.org Change-Id: I60198d2fbcd36c4687b379d07995e1b873112d51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838922 Reviewed-on: https://chromium-review.googlesource.com/1051026 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557048} [modify] https://crrev.com/7da4ea6da89371004a20ab2e157d8ba6aabd57b3/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/7da4ea6da89371004a20ab2e157d8ba6aabd57b3/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1451001d340f4c4d090b7e94b53fc2b0f89fd9f0 commit 1451001d340f4c4d090b7e94b53fc2b0f89fd9f0 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Wed May 09 16:08:40 2018 Reland #1 "Reactivate deflaked keyboard accessory tests" This is a reland of dc92f9dbb51a25f4e85f65b38b9b99218294c3a8 With this reland, only one of the tests is reenabled again. The one that doesn't fail and is unrelated to the other two. (Therefore, the font changes are not needed anymore - this will follow in a second reland CL). Original change's description: > Reactivate deflaked keyboard accessory tests > > After having landed https://crrev.com/c/1028230, the problems of the > linked bug seem to have gone (as assumed). > > I removed the Disabling and RetryOnFailure annotations to test on 3 > devices (one physical, two emulator with different screen sizes and OS) > and couldn't find a single broken test. > Edit: I changed the font size recently (not finally) which seems to > bother some bots - unrelated from the filed bug. Changed that back. > > This CL now reenables all the tests but keeps the RetryOnFailure > annotation. That way, I can test whether the tests start failing on > some bots again without making the sheriffs life harder. > If the bots don't notice any flakiness, I will remove the > RetryOnFailure annotation as well and mark the linked bug fixed. > > Bug: 838922 > Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4 > Reviewed-on: https://chromium-review.googlesource.com/1044371 > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556798} Bug: 838922 Change-Id: I18dda9ed9df416a796fa1748032f37adb0224dd0 Reviewed-on: https://chromium-review.googlesource.com/1051831 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#557208} [modify] https://crrev.com/1451001d340f4c4d090b7e94b53fc2b0f89fd9f0/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
,
Jan 9
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 2 2018