Network Service needs a way to SetSSLKeyLogFile |
|||||||||||||
Issue descriptionKey logging is enabled by setting the environment variable SSLKEYLOGFILE to point to a file. chrome/browser/io_thread.cc currently parses this from the command_line and call net::SSLClientSocket::SetSSLKeyLogFile to set it. With network service, we will need to support this feature. If we want this to be sandbox-friendly, we can pass a file handle to the network service. This is filed off mmenke@'s starter list. If anyone has free cycles, please take it.
,
May 18 2018
,
Jun 12 2018
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd37c178d9dac3e15380ee51092274f34cb3c1a6 commit bd37c178d9dac3e15380ee51092274f34cb3c1a6 Author: David Benjamin <davidben@chromium.org> Date: Wed Jul 11 17:24:57 2018 Split SSLKeyLogger into an interface and implementation. Someday in the future, the network service will be sandboxed, at which point file access won't be allowed. We still need to deal with the SSLClientContext mess but we can do the interface split now. This also removes an OS_NACL special-case. Bug: 838910 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I607f18b26a357de56b13aa2453caa2f40f2ecacb Reviewed-on: https://chromium-review.googlesource.com/1128189 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#574212} [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/chrome/browser/io_thread.cc [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/components/cronet/ios/cronet_environment.mm [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/components/cronet/url_request_context_config.cc [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/headless/app/headless_shell.cc [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/net/BUILD.gn [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/net/socket/ssl_client_socket.cc [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/net/socket/ssl_client_socket.h [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/net/socket/ssl_client_socket_impl.cc [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/net/socket/ssl_client_socket_impl.h [modify] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/net/ssl/ssl_key_logger.h [rename] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/net/ssl/ssl_key_logger_impl.cc [add] https://crrev.com/bd37c178d9dac3e15380ee51092274f34cb3c1a6/net/ssl/ssl_key_logger_impl.h
,
Jul 24
This doesn't seem like it should block canary
,
Jul 24
,
Jul 24
,
Sep 4
,
Sep 6
,
Sep 7
any updates on this bug? please let me know if you can finish in the 2-3 weeks. If not, i can redistribute.
,
Sep 7
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7
,
Sep 19
,
Sep 19
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08512341525ade51dba02050a00ccbae0c0b6956 commit 08512341525ade51dba02050a00ccbae0c0b6956 Author: Doug Turner <dougt@chromium.org> Date: Mon Sep 24 20:54:19 2018 Allow SetSSLKeyLogFile support in Network Service Bug: 838910 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id40fa8876356c3ecdac81999f1701bb0ef420393 Reviewed-on: https://chromium-review.googlesource.com/1234842 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#593669} [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/chrome/browser/io_thread.cc [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/chrome/common/chrome_switches.cc [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/chrome/common/chrome_switches.h [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/content/browser/network_service_instance.cc [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/services/network/network_service.cc [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/services/network/network_service.h [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/services/network/public/cpp/network_switches.cc [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/services/network/public/cpp/network_switches.h [modify] https://crrev.com/08512341525ade51dba02050a00ccbae0c0b6956/services/network/public/mojom/network_service.mojom
,
Sep 24
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by dxie@chromium.org
, May 15 2018