Issue metadata
Sign in to add a comment
|
Site engagement entries not removed correctly |
||||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3409.2 OS: Linux What steps will reproduce the problem? (1) Go to facebook.com (2) Close tab (3) Delete the entry for facebook.com from chrome://history (4) Go to chrome://site-engagement What is the expected result? facebook.com should not be visible anymore What happens instead? I still see the following entries: Origin Base Bonus Total http://www.facebook.com/ 0 0 0 https://www.facebook.com/ 0 0 0
,
May 7 2018
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c794d97162f4ef484cc1cc2c7c4c3abd96f61fb commit 1c794d97162f4ef484cc1cc2c7c4c3abd96f61fb Author: Christian Dullweber <dullweber@chromium.org> Date: Tue May 08 09:47:42 2018 Remove origins with zero engagement When urls are removed from chrome://history, the site-engagement score is not removed if it reaches zero. This CL fixes the issue as it is not neccessary to keep a score of zero around. Bug: 838875 Change-Id: Ia580ee49f2c4df8cda46f33c36b6551580dafef7 Reviewed-on: https://chromium-review.googlesource.com/1046765 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#556740} [modify] https://crrev.com/1c794d97162f4ef484cc1cc2c7c4c3abd96f61fb/chrome/browser/engagement/site_engagement_service.cc [modify] https://crrev.com/1c794d97162f4ef484cc1cc2c7c4c3abd96f61fb/chrome/browser/engagement/site_engagement_service_unittest.cc
,
May 8 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dullweber@chromium.org
, May 2 2018