Issue metadata
Sign in to add a comment
|
Regression : Space issue is seen between 'CONFIGURE" button and DISCONNECT' button in chrome://settings |
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3416.0/10638.0.0 dev-channel Reks,Daisy and Candy OS: Chrome What steps will reproduce the problem? (1) Sign in to user -> go to chrome://settings page -> At 'Network' section click on Wi-Fi -> select Connected Wi-Fi network (2)Now click on 'DISCONNECT' -> observe 'CONFIGURE" button is seen -> Now observe there is no proper space between 'CONFIGURE" button and DISCONNECT' button (Please refer Video and Screenshot) This is Regression Issue as same is working fine in 68.0.3405.0/10631.0.0 dev-channel Reks @stevenjb: Please confirm the issue
,
May 3 2018
IIUC, the spacing is same as before the button style change. Previously the buttons only showed a background when focused, which made the fact that they are too close to each other not apparent. Now the buttons have a border/background which reveals the fact that they are too close. Adding some reasonable margin between them should solve the issue.
,
Jun 6 2018
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17573c429dad1deee0c668f3933efc21e6b61a3a commit 17573c429dad1deee0c668f3933efc21e6b61a3a Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jun 11 20:29:20 2018 settings: Internet: Fix configure button spacing and vis This CL: * Hides the 'configure' button for non secure WiFi networks (there is nothing to configure). * Fixes the spacing for the 'connect' and 'disconnect' buttons. Bug: 826242 , 838868 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id447a929234b90bfa4064a5daa88e5df6e95a4a4 Reviewed-on: https://chromium-review.googlesource.com/1089469 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#566131} [modify] https://crrev.com/17573c429dad1deee0c668f3933efc21e6b61a3a/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/17573c429dad1deee0c668f3933efc21e6b61a3a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
Jun 11 2018
,
Jun 26 2018
This didn't make the 68 cut. It's a small change and looks pretty bad.
,
Jun 26 2018
Issue 845606 has been merged into this issue.
,
Jun 26 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 27 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3002b04d1c1c04e0e5e6d9c884abb38e49d73f3 commit e3002b04d1c1c04e0e5e6d9c884abb38e49d73f3 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Jun 27 19:31:37 2018 settings: Internet: Fix configure button spacing and vis This CL: * Hides the 'configure' button for non secure WiFi networks (there is nothing to configure). * Fixes the spacing for the 'connect' and 'disconnect' buttons. TBR=stevenjb@chromium.org (cherry picked from commit 17573c429dad1deee0c668f3933efc21e6b61a3a) Bug: 826242 , 838868 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id447a929234b90bfa4064a5daa88e5df6e95a4a4 Reviewed-on: https://chromium-review.googlesource.com/1089469 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566131} Reviewed-on: https://chromium-review.googlesource.com/1117464 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#555} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/e3002b04d1c1c04e0e5e6d9c884abb38e49d73f3/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/e3002b04d1c1c04e0e5e6d9c884abb38e49d73f3/chrome/browser/resources/settings/internet_page/internet_detail_page.js
,
Jul 12
Verified on M69 ToT & M68 beta (10718.50.0, 68.0.3440.59). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, May 3 2018Labels: -Pri-1 Pri-2