New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838855 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 844297
issue 846658



Sign in to add a comment

Sad tab gets focused when page is killed from task manager

Reported by frolovki...@gmail.com, May 2 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
I recorded steps on video

What is the expected behavior?

What went wrong?
При закрытии процесса вкладки окно со вкладкой выходит на передний план. 

Did this work before? Yes 65

Chrome version: 66.0.3359.139  Channel: stable
OS Version: 10.0
Flash Version:
 
bandicam 2018-05-02 14-26-22-728.mp4
6.3 MB View Download
Labels: Needs-Bisect Needs-Triage-M66
Cc: susan.boorgula@chromium.org
Labels: Triaged-ET Needs-Feedback
frolovkirill7@ Thanks for the issue.

Tested the issue on Windows 10 on the reported version 66.0.3359.139 and the latest Canary 68.0.3417.2 by following the below steps.

1. Launched Chrome and opened many tabs.
2. Tried closing a tab by clicking on the x button, which is not on the foreground and can observe that the tab is closed without coming to the foreground.
3. Closed a tab by ending the process in the task manager and the tab is closed without coming to the foreground.
Attached is the screen cast for reference.

Request you to check and confirm if anything is missed from our end in triaging the issue.

Thanks..
838855.mp4
1.5 MB View Download
1.Launched Chrome and opened many tabs.
2.I tried to kill active tab process.
3.The browser window unminimized
Project Member

Comment 5 by sheriffbot@chromium.org, May 3 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
frolovkirill7@ Thanks for the update.

Tested this issue on Windows 10 on latest Stable 66.0.3359.139 as per comment #4.

1. Launched Chrome and opened many tabs.
2. Tried killing a active tab by ending a process in Task Manager, Aw Snap is displayed on the page.
The same behavior is observed on M65 builds.
Attached is the screen cast for reference.

Request you to provide the exact details of the issue you are seeing, which will help us in further triaging.
Also provide a screen cast of the steps followed to reproduce the issue.

Thanks..
838855-M66.mp4
1.8 MB View Download
Screencast attached to comment 1.
Project Member

Comment 8 by sheriffbot@chromium.org, May 7 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: manoranj...@chromium.org
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable FoundIn-67 M-66 Target-67 Target-66 FoundIn-66 FoundIn-68 RegressedIn-66 Target-68 OS-Linux Pri-1
Owner: dmazz...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Windows 10 and Ubuntu 14.04 on the latest Canary 68.0.3424.0 and latest Stable 66.0.3359.139 as per the original comment.
Issue is not observed on Mac OS 10.12.6
Attached are the screen casts of Good and Bad behaviors.

Bisect Information:
===================
Good Build: 66.0.3344.0 (Revision - 535592)
Bad Build : 66.0.3345.0 (Revision - 536026)

Unable to execute the per-revision bisect script as all builds are crashing. Hence below is the Changelog URL by executing the Chromium bisect:

https://chromium.googlesource.com/chromium/src/+log/cf3e96da896ecf7715f85d5c71283f4ab53db112..a60e495ea2084539e350f51125843dc207868d58

From the above Changelog, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/910716

dmazzoni@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Adding ReleaseBlock-Stable as this is a recent regression. Please feel free to remove the same if this is not applicable.

Thanks
838855-good.mp4
690 KB View Download
838855-bad.mp4
448 KB View Download
Labels: -M-66 M-67
Punting this to M67.
To clarify, is the behavior change that the window with the sad tab comes to the foreground?

This is a side effect of an intentional change. The goal was to put keyboard focus into the sad tab when it appears, so that users with a screen reader or who prefer keyboard navigation have a good experience.

I think we should maybe tweak it so that we only put focus there if the window was already active. In the case where the Task Manager was active and the window containing the tab was behind it, we should do nothing.

I'll accept this and will fix it, but I don't think this needs to be a release blocker.

Labels: -Arch-x86_64 -ReleaseBlock-Stable -hasbisect-per-revision -Via-Wizard-UI -M-67 -Triaged-ET -Target-66 -Target-67 -Needs-Triage-M66 M-68
Removing some labels. Not a release blocker but will target M68 with a fix.

Summary: Sad tab gets focused when page is killed from task manager (was: При закрытии процесса вкладки окно со вкладкой выходит на передний план. При закрытии процесса фоновой вкладки эффекта не наблюдается)
Blocking: 844297
Blocking: 846658
Project Member

Comment 17 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0778cbc504f75db4521f284c784340888c2469b5

commit 0778cbc504f75db4521f284c784340888c2469b5
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue May 29 16:24:53 2018

Only focus the sad tab view if its widget is already active.

In crrev.com/c/910716, I made it so that a button on the sad tab view
takes focus when the sad tab appears, which improves accessibility.
This had the side effect of activating the window if it was previously
in the background. Fix this by only focusing the view in the sad tab
if its widget is already active.

Bug:  838855 
Change-Id: Ia70279fd010a03c5185e6c4b9f1c85168fce899a
Reviewed-on: https://chromium-review.googlesource.com/1073494
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562455}
[modify] https://crrev.com/0778cbc504f75db4521f284c784340888c2469b5/chrome/browser/ui/views/sad_tab_view.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-69.0.3445.0 TE-Verified-M69
Able to reproduce this issue on Windows 10 and Ubuntu 14.04 on the reported version 66.0.3359.139 and the issue is fixed on the latest Canary 69.0.3445.0 as per comment #9.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
838855-M69-CL.mp4
1013 KB View Download
Cc: phanindra.mandapaka@chromium.org
 Issue 851280  has been merged into this issue.

Sign in to add a comment