New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838850 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus traversal is not seen on Notifications

Project Member Reported by kebalaji@chromium.org, May 2 2018

Issue description

Chrome Version:68.0.3416.0/10638.0.0 dev channel Daisy, Candy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Get some notifications (Eg: take screenshot) >> Click on Notifications icon and keep tabbing and observe

Expected: Focus traversal should be seen
Actual: Focus is missing 

This is a Regression issue as same is working fine in 68.0.3405.0/10614.0.0 dev

@Yoshiki: Please confirm the issue
 
ActualNotfocus.mp4
3.8 MB View Download
ExpectedNotfocus.mp4
3.2 MB View Download
Cc: yoshiki@chromium.org
Labels: Needs-Bisect
Owner: tetsui@chromium.org
I think the entire ash focus painter e.g. in SystemTray is broken on ToT. 
Cc: yawano@chromium.org
Regression CL detected: https://crrev.com/c/1009243
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cfb7f6f5edf4c04958b205ceb831a8cca5fe1e5

commit 9cfb7f6f5edf4c04958b205ceb831a8cca5fe1e5
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Tue May 08 03:29:12 2018

Revert "Remove border outline when focused when tab key is used."

This reverts commit edd33a2ca7de7569e1f5198ce5311772f0da9d2e.

Reason for revert: All ash focus rings are broken

Original change's description:
> Remove border outline when focused when tab key is used.
>
> Bug: b/74415372
> Test: Manually Tested
> Change-Id: I4e3e5a5b48054b6a7c59e2a02b38b0d200885fee
> Reviewed-on: https://chromium-review.googlesource.com/1009243
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Sara Kato <sarakato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554301}

TBR=yoshiki@chromium.org,oshima@chromium.org,yawano@chromium.org,sarakato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

BUG=b/74415372,838850

Change-Id: Id2bafab905a039f634ebcf62a6ab0f919274564d
Reviewed-on: https://chromium-review.googlesource.com/1049205
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556677}
[modify] https://crrev.com/9cfb7f6f5edf4c04958b205ceb831a8cca5fe1e5/ash/message_center/notifier_settings_view.cc
[modify] https://crrev.com/9cfb7f6f5edf4c04958b205ceb831a8cca5fe1e5/ash/public/cpp/ash_constants.h
[modify] https://crrev.com/9cfb7f6f5edf4c04958b205ceb831a8cca5fe1e5/ui/message_center/public/cpp/message_center_constants.h
[modify] https://crrev.com/9cfb7f6f5edf4c04958b205ceb831a8cca5fe1e5/ui/message_center/views/padded_button.cc

Cc: sammiequon@chromium.org x...@chromium.org tbuck...@chromium.org sarakato@chromium.org
 Issue 838424  has been merged into this issue.
Status: Fixed (was: Started)

Sign in to add a comment