New issue
Advanced search Search tips

Issue 838835 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"SitePerProcessHitTestBrowserTest.InputEventRouterTouchpadGestureTargetTest/1" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 2 2018

Issue description

"SitePerProcessHitTestBrowserTest.InputEventRouterTouchpadGestureTargetTest/1" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5JbnB1dEV2ZW50Um91dGVyVG91Y2hwYWRHZXN0dXJlVGFyZ2V0VGVzdC8xDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 824592 .
 

Comment 1 by treib@chromium.org, May 3 2018

Cc: mcnee@chromium.org sahel@chromium.org
Labels: OS-Chrome OS-Linux OS-Windows
Owner: riajiang@chromium.org
Status: Assigned (was: Untriaged)
/0 seems to be fine, but both /1 and /2 are indeed flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=SitePerProcessHitTestBrowserTest.InputEventRouterTouchpadGestureTargetTest

I'll go ahead and disable the test. Assigning and CCing some people who recently touched this, please take a look or triage further.
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a1dc16c178d9aa853a91f0066ab914d575d180

commit 92a1dc16c178d9aa853a91f0066ab914d575d180
Author: Marc Treib <treib@chromium.org>
Date: Thu May 03 13:51:26 2018

Disable flaky SitePerProcessHitTestBrowserTest.InputEventRouterTouchpadGestureTargetTest

TBR=riajiang@chromium.org

Bug: 838835
Change-Id: Ie69310cde0d51472d3446c57b8bbd66bc703a602
Reviewed-on: https://chromium-review.googlesource.com/1041957
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555710}
[modify] https://crrev.com/92a1dc16c178d9aa853a91f0066ab914d575d180/content/browser/site_per_process_hit_test_browsertest.cc

Comment 3 by treib@chromium.org, May 3 2018

Labels: -Sheriff-Chromium Test-Disabled SitePerProcessHitTestBrowserTest.InputEventRouterTouchpadGestureTargetTest

Comment 4 by mcnee@chromium.org, May 3 2018

Components: Internals>Sandbox>SiteIsolation

Comment 5 by mcnee@chromium.org, May 3 2018

Cc: kenrb@chromium.org wjmaclean@chromium.org
Since it's versions /1 and /2 (viz hit testing) that are flaky, I'll re-enable the non-viz hit testing case: https://chromium-review.googlesource.com/c/chromium/src/+/1042487
Project Member

Comment 6 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d129ed85feafc7fb807d741f962edb05047acff

commit 9d129ed85feafc7fb807d741f962edb05047acff
Author: Kevin McNee <mcnee@chromium.org>
Date: Thu May 03 17:05:13 2018

Only disable InputEventRouterTouchpadGestureTargetTest under viz hit testing

Versions /1 and /2 (viz hit testing) are flaky, but /0 is fine, so we'll
keep /0 enabled.

Bug: 838835
Change-Id: If535c37a49d8f251283712f7b2e280ad60efebd9
Reviewed-on: https://chromium-review.googlesource.com/1042487
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555774}
[modify] https://crrev.com/9d129ed85feafc7fb807d741f962edb05047acff/content/browser/site_per_process_hit_test_browsertest.cc

From https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5JbnB1dEV2ZW50Um91dGVyVG91Y2hwYWRHZXN0dXJlVGFyZ2V0VGVzdC8xDA, it looks like it happened very infrequently and was only on windows. I haven't found anything that would make it flaky yet. Will re-enable it on other platforms first.
Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec01ea9ce1b668d88f715373daf56fd392c53274

commit ec01ea9ce1b668d88f715373daf56fd392c53274
Author: Ria Jiang <riajiang@chromium.org>
Date: Thu May 17 16:19:18 2018

Re-enable InputEventRouterTouchpadGestureTargetTest and InputEventRouterGestureTargetMapTest on non-win platforms.

InputEventRouterTouchpadGestureTargetTest and
InputEventRouterGestureTargetMapTest in
SitePerProcessHitTestBrowserTest are flaky for Viz hit-test but only
on Windows. Re-enable them on other platforms.

Bug: 838835,  823578 
Change-Id: I91d332036cb546d3606b3ea483b865496bc5a918
Reviewed-on: https://chromium-review.googlesource.com/1062828
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559557}
[modify] https://crrev.com/ec01ea9ce1b668d88f715373daf56fd392c53274/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8976f940cfd7d12d31012f26c4d416d5b238f587

commit 8976f940cfd7d12d31012f26c4d416d5b238f587
Author: Ria Jiang <riajiang@chromium.org>
Date: Thu Jul 26 19:23:09 2018

Tentatively enable some SitePerProcessHitTestBrowserTest flaky tests.

RootConsumesScrollDuringOverscrollGesture,
InputEventRouterTouchpadGestureTargetTest and
TouchpadPinchOverOOPIF were flaky tests with Viz hit-testing config.
However, looking at the log, they only happened infrequently on Android
and Windows. I couldn't repro these locally and there have been some
changes with how we wait for hit-test data and setting initial window
bounds, so tentatively re-enable these three tests to see whether they
are still flaky or not.

Bug: 853761, 835058, 838835
Change-Id: I66ae6162ab9065e4a940c5779adb92254a6bf54c
Reviewed-on: https://chromium-review.googlesource.com/1151899
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578398}
[modify] https://crrev.com/8976f940cfd7d12d31012f26c4d416d5b238f587/content/browser/site_per_process_hit_test_browsertest.cc

Sign in to add a comment