New issue
Advanced search Search tips

Issue 838829 link

Starred by 13 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Device frame not available for newer devices (Pixel 2 and iPhone X)

Reported by arnab...@gmail.com, May 2 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3409.0 Safari/537.36

Steps to reproduce the problem:
1. Open dev tools
2. Choose a mobile device such as Pixel 2 or iPhone X
3. Choose 'Show device frame'

What is the expected behavior?
Device frame is displayed for the selected device

What went wrong?
Device frame is not displayed for newer devices such as  Pixel 2 or iPhone X

Did this work before? N/A 

Chrome version: 68.0.3409.0  Channel: canary
OS Version: OS X 10.13.4
Flash Version:
 
Screen Shot 2018-05-02 at 11.59.08.png
954 KB View Download
Screen Shot 2018-05-02 at 11.59.24.png
949 KB View Download
Labels: Needs-Triage-M68
Components: -UI Platform>DevTools>Mobile
Labels: M-68 Triaged-ET FoundIn-68 Target-68 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.13.3, Win-10 and Ubuntu 14.04 using chrome reported version #68.0.3409.0.
This is a non-regression issue as it is observed from M64 old builds. 
Note: From M-63, the iphone X or pixel 2 is not present in the device list.
Hence, marking it as untriaged to get more inputs from dev team.

Thanks...!!

Comment 3 by alph@chromium.org, May 11 2018

Labels: -Type-Bug Type-Feature
Owner: alph@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by poo...@moblize.it, Jun 10 2018

very much needed
NEED this
Hey guys,
I've only been able to see about 4-5 device frames for as long as I can remember, am I missing something?

However, while using Canary, no device frames are visible although I can see room is attempted to be made for them when I select a device that I know usually shows up in regular chrome.
Owner: binghamj@chromium.org
Do we want to support skins for all the new devices? Where do we get the graphics?
I kind of wonder what the point is in these frames, and how request for simulation of notches and keyboard spaces (to test layouts changes) can be refused due to they being too much effort/complicated, when people are considering spending time on something totally cosmetic...correct me if I'm wrong, but I'd much rather have notches/keyboardspace/etc.
If it was just a cosmetic frame, that would make sense. There are innumerable sites and tools to add a simple frame overlay to a screenshot.

Where this tool can definitely excel is in those weird layouts, e.g. iPhone X (and now other device) notch and home indicator bar (the former only in landscape view) or with keyboard simulation. That could really make the Chrome dev tools a good first-pass tool for design considerations on these handsets.

But building them will be more complicated than adding new frames, since the current frames only wrap around (and don't extend into) the viewport.

For those reading this issue without a phone with a notch or home indicator, here's what that looks like in portrait and landscape, with the frame added back onto the screenshots.
IMG_0043.PNG
1.3 MB View Download
Indeed, I agree, that this should be emulating notches, layout changes due to keyboard, and other device UI (like the toolbar that pops up when the user touches the bottom of a full screen page). Simply providing skinning is a waste of time (imo).

Sign in to add a comment