Set background color of highlighted state of the table view items |
|||||||||
Issue descriptionPer comment #2, the highlighted state of table view cells should be: A full width/height view with a background color of black @ 0.05 alpha. Creating a bug to close the other one, maybe it is a duplicate.
,
May 2 2018
Sorry, I meant comment #2 of issue 834201
,
May 2 2018
,
May 23 2018
,
Jun 26 2018
This should apply to all UIRefresh collections
,
Jun 26 2018
Issue 856634 has been merged into this issue.
,
Aug 7
,
Aug 13
Martijn, what should be the color for the highlighted cell in a black background? (e.g. Recents Tabs in Tab Grid). The current color being used in the Tools Menu is barely noticeable over black background. Please re-assign to me after we pick a color
,
Aug 14
Good call. For dark theme let's make the highlighted state: white @ 0.07 alpha
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a632a41c18b977ed5552287bcd1a4241fd722afe commit a632a41c18b977ed5552287bcd1a4241fd722afe Author: sczs <sczs@chromium.org> Date: Tue Aug 21 16:54:12 2018 [ios] Uses the styler to set ChromeTableVC cell highlight color Bug: 838823 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If039925b436a01310906be0bbf74807f3310b2cc Reviewed-on: https://chromium-review.googlesource.com/1176862 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584790} [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/tab_grid/grid/grid_constants.h [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/tab_grid/grid/grid_constants.mm [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.h [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.mm [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/cells/table_view_item.mm [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.h [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.mm [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/chrome_table_view_styler.h [modify] https://crrev.com/a632a41c18b977ed5552287bcd1a4241fd722afe/ios/chrome/browser/ui/table_view/chrome_table_view_styler.mm
,
Aug 21
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by gambard@chromium.org
, May 2 2018