Ensure experimental LUCI builds don't interfere with production builds |
|||
Issue descriptionSome examples of problems: https://ci.chromium.org/p/webrtc/builders/luci.webrtc.ci/Linux64%20Release/1 "is_experimental": false (should be true) https://build.chromium.org/p/client.webrtc/builders/iOS API Framework Builder uploads stuff, don't want to duplicate the work
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/dfccb9f184cc015eb97f2a98f05fd2f00b82a8d5 commit dfccb9f184cc015eb97f2a98f05fd2f00b82a8d5 Author: Oleh Prypin <oprypin@webrtc.org> Date: Fri May 25 06:38:27 2018 WebRTC: Still upload from experimental builds, but to a different path Bug: chromium:838818 Change-Id: Ie1c03e4bf4cf00aa1f061513441fbebfb8eff644 Reviewed-on: https://chromium-review.googlesource.com/1071513 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> [modify] https://crrev.com/dfccb9f184cc015eb97f2a98f05fd2f00b82a8d5/scripts/slave/README.recipes.md [modify] https://crrev.com/dfccb9f184cc015eb97f2a98f05fd2f00b82a8d5/scripts/slave/recipe_modules/webrtc/api.py [modify] https://crrev.com/dfccb9f184cc015eb97f2a98f05fd2f00b82a8d5/scripts/slave/recipes/webrtc/ios_api_framework.py
,
May 25 2018
Unsurprisingly, this started producing errors. webrtc-ci-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to chromium-webrtc We'll need to add the permission.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/1174cae19a3ff2f3db6c50f87bfd852a6762543b commit 1174cae19a3ff2f3db6c50f87bfd852a6762543b Author: Oleh Prypin <oprypin@webrtc.org> Date: Thu May 31 11:12:58 2018 Revert "WebRTC: Still upload from experimental builds, but to a different path" This reverts commit dfccb9f184cc015eb97f2a98f05fd2f00b82a8d5. Reason for revert: We don't need to test uploads on LUCI anymore Original change's description: > WebRTC: Still upload from experimental builds, but to a different path > > Bug: chromium:838818 > Change-Id: Ie1c03e4bf4cf00aa1f061513441fbebfb8eff644 > Reviewed-on: https://chromium-review.googlesource.com/1071513 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> TBR=phoglund@chromium.org,oprypin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:838818 Change-Id: I65634747509be502f81d17a39942875d9b5afe83 Reviewed-on: https://chromium-review.googlesource.com/1079547 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Reviewed-by: Oleh Prypin <oprypin@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> [modify] https://crrev.com/1174cae19a3ff2f3db6c50f87bfd852a6762543b/scripts/slave/README.recipes.md [modify] https://crrev.com/1174cae19a3ff2f3db6c50f87bfd852a6762543b/scripts/slave/recipe_modules/webrtc/api.py [modify] https://crrev.com/1174cae19a3ff2f3db6c50f87bfd852a6762543b/scripts/slave/recipes/webrtc/ios_api_framework.py
,
May 31 2018
,
Jun 7 2018
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable? |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 2 2018