New issue
Advanced search Search tips

Issue 838794 link

Starred by 3 users
Status: Fixed
Owner:
sangwoo108@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to perform google search by dragging selected text in tab-strip.

Reported by avsha...@etouch.net, May 2 2018 
Chrome Version : 68.0.3417.0 (Official Build) dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1-refs/heads/master@{#555217} 32/64-bit
OS : Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://version page.
2. Select any text from the page and try to drag it in tab-strip
3. Observe.

Actual Result : Unable to perform google search by dragging any selected text in tab-strip.

Expected Result : Chrome should allow user to perform google search by dragging selected text in tab-strip.

This is a regression issue, broken in M-68 and will soon update remaining info.
Good Build : 68.0.3416.0
Bad Build : 68.0.3417.0
Actual_Result.mp4
884 KB View Download
Expected_Result.mp4
1.5 MB View Download

Comment 1 by avsha...@etouch.net, May 2 2018

Labels: RegressedIn-68 hasbisect FoundIn-68 Target-68 OS-Linux
Owner: sangwoo108@chromium.org
Status: Assigned (was: Unconfirmed)
(Getting 'No enough builds..' error while performing bisect with per-revision script hence providing the bisect using old script)

This is a regression issue, broken in M-68 and providing the bisect using old script:
Good Build : 68.0.3416.0 (Revision : 554962)
Bad Build : 68.0.3417.0 (Revision : 555217)

You are probably looking for a change made after 555014 (known good), but no later than 555017 (first known bad).

Narrow Bisect URL :
https://chromium.googlesource.com/chromium/src/+log/8e65322c96d561a0843abda29e92f6372fb84974..8ed2d37ac3f646d4cb292a6f809ea1e549e91dde

Suspect : https://chromium.googlesource.com/chromium/src/+/9d8d6c4a0c9c386bcbe6e03d958d91f6c45ad009

@sangwoo : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue is also observed on Linux(14.04 LTS) OS but the same issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.5) OS.

Comment 2 by nyerramilli@chromium.org, May 2 2018

Labels: ReleaseBlock-Stable
marking as RBS, please change if required

Comment 3 by sangwoo108@chromium.org, May 3 2018

Status: Started (was: Assigned)
Yes. My previous patch seems to cause this. Thank you for reporting this.
Project Member

Comment 4 by bugdroid1@chromium.org, May 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f55724a1985d27dfe572ab4796ed1b6ba2f8dc5

commit 0f55724a1985d27dfe572ab4796ed1b6ba2f8dc5
Author: sangwoo.ko <sangwoo108@chromium.org>
Date: Sat May 05 05:57:11 2018

Allow plain strings to be dropped

As we can convert plain strings into query url,
We shouldn't block non-urls.

Bug:  838794 
Change-Id: Iaceaf0627a95c11382a4dee72d62a7af2a4e78bd
Reviewed-on: https://chromium-review.googlesource.com/1041367
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556310}
[modify] https://crrev.com/0f55724a1985d27dfe572ab4796ed1b6ba2f8dc5/chrome/browser/ui/views/frame/browser_root_view.cc
[modify] https://crrev.com/0f55724a1985d27dfe572ab4796ed1b6ba2f8dc5/chrome/browser/ui/views/frame/browser_root_view_browsertest.cc

Comment 5 by sangwoo108@chromium.org, May 5 2018

Status: Fixed (was: Started)

Comment 6 by sangwoo108@chromium.org, May 10 2018 

@avshaikh Could you verify this, please?

Comment 7 by avsha...@etouch.net, May 10 2018

Labels: TE-Verified-68.0.3426.0 TE-Verified-M68
Hi @sangwoo

Tested above issue in today's Canary build #68.0.3426.0 on Win(7,8,8.1,10), Linux(14.04 LTS) OS and the issue is fixed. Now chrome allows to drag and drop plain text in tab strip and performs google search for dropped query. Kindly review an attached screen-cast.

Thank you..!
Canary_build_behaviour.mp4
1.8 MB View Download
►

Sign in to add a comment